ash: Process double-click event only for left-button clicks.

ash/wm/workspace/workspace_event_handler_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/workspace/workspace_event_handler.h"
 
 #include "ash/screen_ash.h"
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/wm/property_util.h"
 #include "ash/wm/window_util.h"
 #include "ash/wm/workspace_controller.h"
 #include "ash/wm/workspace_controller_test_helper.h"
 #include "ui/aura/client/aura_constants.h"
+#include "ui/aura/root_window.h"
 #include "ui/aura/test/event_generator.h"
 #include "ui/aura/test/test_window_delegate.h"
 #include "ui/aura/window.h"
+#include "ui/aura/window_property.h"
 #include "ui/base/hit_test.h"
 #include "ui/gfx/screen.h"
 
 #if defined(OS_WIN)
 #include "base/win/windows_version.h"
 #endif
 
 namespace ash {
 namespace internal {
 
@@ skipping 11 matching lines @@
     SetDefaultParentByPrimaryRootWindow(window);
     window->SetBounds(bounds);
     window->Show();
     return window;
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(WorkspaceEventHandlerTest);
 };
 
+// Keeps track of the properties changed of a particular window.
+class WindowPropertyObserver : public aura::WindowObserver {
+ public:
+  explicit WindowPropertyObserver(aura::Window* window)
+      : window_(window) {
+    window->AddObserver(this);
+  }
+
+  virtual ~WindowPropertyObserver() {
+    window_->RemoveObserver(this);
+  }
+
+  bool DidPropertyChange(const void* property) const {
+    return std::find(properties_changed_.begin(),
+                     properties_changed_.end(),
+                     property) != properties_changed_.end();
+  }
+
+ private:
+  virtual void OnWindowPropertyChanged(aura::Window* window,
+                                       const void* key,
+                                       intptr_t old) OVERRIDE {
+    properties_changed_.push_back(key);
+  }
+
+  aura::Window* window_;
+  std::vector<const void*> properties_changed_;
+
+  DISALLOW_COPY_AND_ASSIGN(WindowPropertyObserver);
+};
+
 TEST_F(WorkspaceEventHandlerTest, DoubleClickSingleAxisResizeEdge) {
   // Double clicking the vertical resize edge of a window should maximize it
   // vertically.
   gfx::Rect restored_bounds(10, 10, 50, 50);
   aura::test::TestWindowDelegate wd;
   scoped_ptr<aura::Window> window(CreateTestWindow(&wd, restored_bounds));
 
   wm::ActivateWindow(window.get());
 
   gfx::Rect work_area = Shell::GetScreen()->GetDisplayNearestWindow(
@@ skipping 153 matching lines @@
   EXPECT_EQ(restored_bounds.x(), window->bounds().x());
   EXPECT_EQ(restored_bounds.width(), window->bounds().width());
 }
 
 TEST_F(WorkspaceEventHandlerTest, DoubleClickCaptionTogglesMaximize) {
   aura::test::TestWindowDelegate wd;
   scoped_ptr<aura::Window> window(CreateTestWindow(&wd, gfx::Rect(1, 2, 3, 4)));
   window->SetProperty(aura::client::kCanMaximizeKey, true);
   wd.set_window_component(HTCAPTION);
   EXPECT_FALSE(wm::IsWindowMaximized(window.get()));
-  aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
-                                       window.get());
+  aura::RootWindow* root = Shell::GetPrimaryRootWindow();
+  aura::test::EventGenerator generator(root, window.get());
   generator.DoubleClickLeftButton();
   EXPECT_NE("1,2 3x4", window->bounds().ToString());
 
   EXPECT_TRUE(wm::IsWindowMaximized(window.get()));
   generator.DoubleClickLeftButton();
 
   EXPECT_FALSE(wm::IsWindowMaximized(window.get()));
   EXPECT_EQ("1,2 3x4", window->bounds().ToString());
+
+  // Double-clicking the middle button shouldn't toggle the maximized state.
+  WindowPropertyObserver observer(window.get());
+  ui::MouseEvent press(ui::ET_MOUSE_PRESSED, generator.current_location(),
+                       generator.current_location(),
+                       ui::EF_MIDDLE_MOUSE_BUTTON | ui::EF_IS_DOUBLE_CLICK);
+  root->AsRootWindowHostDelegate()->OnHostMouseEvent(&press);
+  ui::MouseEvent release(ui::ET_MOUSE_RELEASED, generator.current_location(),
+                         generator.current_location(),
+                         ui::EF_IS_DOUBLE_CLICK);
+  root->AsRootWindowHostDelegate()->OnHostMouseEvent(&release);
+
+  EXPECT_FALSE(wm::IsWindowMaximized(window.get()));
+  EXPECT_EQ("1,2 3x4", window->bounds().ToString());
+  EXPECT_FALSE(observer.DidPropertyChange(aura::client::kShowStateKey));
 }
 
 TEST_F(WorkspaceEventHandlerTest, DoubleTapCaptionTogglesMaximize) {
   aura::test::TestWindowDelegate wd;
   gfx::Rect bounds(10, 20, 30, 40);
   scoped_ptr<aura::Window> window(CreateTestWindow(&wd, bounds));
   window->SetProperty(aura::client::kCanMaximizeKey, true);
   wd.set_window_component(HTCAPTION);
   EXPECT_FALSE(wm::IsWindowMaximized(window.get()));
   aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
@@ skipping 42 matching lines @@
   ASSERT_TRUE(aura::client::GetWindowMoveClient(window->parent()));
   base::MessageLoop::current()->DeleteSoon(FROM_HERE, window.get());
   aura::client::GetWindowMoveClient(window->parent())
       ->RunMoveLoop(window.release(),
                     gfx::Vector2d(),
                     aura::client::WINDOW_MOVE_SOURCE_MOUSE);
 }
 
 }  // namespace internal
 }  // namespace ash