components/ntp_snippets/ntp_snippets_fetcher.h - Issue 2239653002: Add robustness against OAuth2 Token requests getting canceled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_fetcher.h

Issue 2239653002: Add robustness against OAuth2 Token requests getting canceled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Marc's comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/ntp_snippets/ntp_snippets_fetcher.h

diff --git a/components/ntp_snippets/ntp_snippets_fetcher.h b/components/ntp_snippets/ntp_snippets_fetcher.h

index 11a4e40f568433f00c4529dd1e40d0dfb785f806..74face472daaa105eaf839b66b161b0c19d465ad 100644

--- a/components/ntp_snippets/ntp_snippets_fetcher.h

+++ b/components/ntp_snippets/ntp_snippets_fetcher.h

@@ -230,6 +230,9 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,

// Request throttler for limiting requests.

RequestThrottler request_throttler_;

+ // When a token request gets canceled, we want to retry for _one_ time.

Marc Treib 2016/08/11 10:11:03 nit: s/for one time/once/

jkrcal 2016/08/11 12:31:48 Done.

+ bool oauth_token_retried_;

base::WeakPtrFactory<NTPSnippetsFetcher> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(NTPSnippetsFetcher);

« no previous file with comments | « no previous file | components/ntp_snippets/ntp_snippets_fetcher.cc » ('j') | no next file with comments »