Issue 27053. Record errors in InferStaticVariableTypeTask and include them into unit errors.

Issue 27053. Record errors in InferStaticVariableTypeTask and include them into unit errors.

R=brianwilkerson@google.com, jmesserly@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/296d81f60a91f60206fda5a15452cb81b06ea938

[Jennifer Messerly, 2016-08-11 13:39:37]

lgtm!!!

https://codereview.chromium.org/2239613002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/2239613002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:4057: class MyErrorListener implements
AnalysisErrorListener {
was this for debugging?

[Brian Wilkerson, 2016-08-11 13:50:51]

I would like us to verify that we need this change before we proceed. My memory
matches Leaf's, that we intentionally didn't collect errors in some tasks
because we would be re-doing the work later and needed to avoid duplication.

[Jennifer Messerly, 2016-08-11 13:51:12]

On 2016/08/11 13:39:37, John Messerly wrote:
> lgtm!!!
> 
>
https://codereview.chromium.org/2239613002/diff/1/pkg/analyzer/lib/src/task/d...
> File pkg/analyzer/lib/src/task/dart.dart (right):
> 
>
https://codereview.chromium.org/2239613002/diff/1/pkg/analyzer/lib/src/task/d...
> pkg/analyzer/lib/src/task/dart.dart:4057: class MyErrorListener implements
> AnalysisErrorListener {
> was this for debugging?

apparently Leaf was wondering about code being re-resolved:
https://github.com/dart-lang/sdk/issues/27053#issuecomment-239093062

Can't say I've seen that, personally, when debugging. But I don't understand the
static field inference well enough to say for sure it can't happen.

[Brian Wilkerson, 2016-08-11 15:46:00]

lgtm

I'm guessing that we won't see duplicate errors because of our use of
AnalysisError.mergeLists (used in DartErrorTask) will remove any duplicates. It
would be interesting to know how often that method actually removes a duplicate
error, but I'm now convinced that this change won't cause any problems.

[scheglov, 2016-08-11 16:10:36]

Description was changed from

==========
Issue 27053. Record errors in InferStaticVariableTypeTask and include them into
unit errors.

R=brianwilkerson@google.com,jmesserly@google.com
BUG=
==========

to

==========
Issue 27053. Record errors in InferStaticVariableTypeTask and include them into
unit errors.

R=brianwilkerson@google.com, jmesserly@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/296d81f60a91f60206fda5a15452cb81b06ea938
==========

[scheglov, 2016-08-11 16:10:37]

Committed patchset #1 (id:1) manually as
296d81f60a91f60206fda5a15452cb81b06ea938 (presubmit successful).