Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2239603002: [inspector] Remove inspector_protocol_parser_test target. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Remove inspector_protocol_parser_test target. This target introduces a dependency on WebKit/platform which is not the way we want it. Keeping the build files in src/inspector, as they are not used and will be useful later on. BUG=none NOPRESUBMIT=true Committed: https://crrev.com/ab53a8b9ec46f975ba5f221f85138d8c277df045 Cr-Commit-Position: refs/heads/master@{#38587}

Patch Set 1 #

Patch Set 2 : format build files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -115 lines) Patch
M gypfiles/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/inspector/BUILD.gn View 1 3 chunks +30 lines, -37 lines 0 comments Download
M src/inspector/inspector.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M test/BUILD.gn View 3 chunks +0 lines, -10 lines 0 comments Download
M test/bot_default.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/bot_default.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M test/default.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/default.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M test/inspector_protocol_parser_test/BUILD.gn View 1 1 chunk +1 line, -18 lines 0 comments Download
M test/inspector_protocol_parser_test/inspector_protocol_parser_test.gyp View 1 chunk +1 line, -38 lines 0 comments Download
M test/inspector_protocol_parser_test/inspector_protocol_parser_test.isolate View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/run-tests.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
dgozman
Could you please take a look? Current bots situation blocks patches in inspector_protocol. See https://codereview.chromium.org/2226863003/ ...
4 years, 4 months ago (2016-08-11 02:46:54 UTC) #2
Yang
lgtm
4 years, 4 months ago (2016-08-11 03:48:29 UTC) #3
dgozman
On 2016/08/11 03:48:29, Yang wrote: > lgtm Thanks!
4 years, 4 months ago (2016-08-11 03:50:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239603002/1
4 years, 4 months ago (2016-08-11 03:50:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21591)
4 years, 4 months ago (2016-08-11 03:53:14 UTC) #8
Michael Achenbach
lgtm
4 years, 4 months ago (2016-08-11 06:57:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239603002/20001
4 years, 4 months ago (2016-08-11 16:17:10 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21653)
4 years, 4 months ago (2016-08-11 16:19:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239603002/20001
4 years, 4 months ago (2016-08-11 16:44:31 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 16:44:58 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 16:45:20 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab53a8b9ec46f975ba5f221f85138d8c277df045
Cr-Commit-Position: refs/heads/master@{#38587}

Powered by Google App Engine
This is Rietveld 408576698