pkg/barback/lib/barback.dart - Issue 22396004: Make observable transform a barback transform.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/barback/lib/barback.dart

Issue 22396004: Make observable transform a barback transform. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: changes alone (patchset 1 has the existing code, in the new location) Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 library barback;	5 library barback;

6	6

7 export 'src/asset.dart';	7 export 'src/asset.dart';

8 export 'src/asset_id.dart';	8 export 'src/asset_id.dart';

9 export 'src/barback.dart';	9 export 'src/barback.dart';

10 export 'src/errors.dart';	10 export 'src/errors.dart';

11 export 'src/package_provider.dart';	11 export 'src/package_provider.dart';

12 export 'src/transform.dart' show Transform;	12 export 'src/transform.dart' show Transform, Log;
	Bob Nystrom 2013/08/08 22:47:09 Maybe "Logger"? Maybe "Logger"? Siggi Cherem (dart-lang) 2013/08/08 23:10:41 could be. But since that's currently the name in t Show quoted text On 2013/08/08 22:47:09, Bob Nystrom wrote: > Maybe "Logger"? could be. But since that's currently the name in the logging package, I wonder if we want to preemptively prevent naming conflicts. Do we expect to use them for different purposes or do we expect both to converge? I could also add [span] argument there and use logging.Logger here. Thoughts? Maybe easier to chat in person? nweiz 2013/08/08 23:34:57 I don't like the idea of barback exposing either " Show quoted text On 2013/08/08 23:10:41, Siggi Cherem (dart-lang) wrote: > On 2013/08/08 22:47:09, Bob Nystrom wrote: > > Maybe "Logger"? > > could be. But since that's currently the name in the logging package, I wonder > if we want to preemptively prevent naming conflicts. > > Do we expect to use them for different purposes or do we expect both to > converge? I could also add [span] argument there and use logging.Logger here. > > Thoughts? Maybe easier to chat in person? I don't like the idea of barback exposing either "Log" or "Logger". Both of those are very likely to cause name conflicts. Siggi Cherem (dart-lang) 2013/08/09 00:29:54 renamed to TransformLogger Show quoted text On 2013/08/08 23:34:57, nweiz wrote: > On 2013/08/08 23:10:41, Siggi Cherem (dart-lang) wrote: > > On 2013/08/08 22:47:09, Bob Nystrom wrote: > > > Maybe "Logger"? > > > > could be. But since that's currently the name in the logging package, I wonder > > if we want to preemptively prevent naming conflicts. > > > > Do we expect to use them for different purposes or do we expect both to > > converge? I could also add [span] argument there and use logging.Logger here. > > > > Thoughts? Maybe easier to chat in person? > > I don't like the idea of barback exposing either "Log" or "Logger". Both of > those are very likely to cause name conflicts. renamed to TransformLogger
13 export 'src/transformer.dart';	13 export 'src/transformer.dart';

OLD	NEW

« no previous file with comments | « no previous file | pkg/barback/lib/src/transform.dart » ('j') | pkg/barback/lib/src/transform.dart » ('J')