pkg/codegen/lib/codegen.dart - Issue 22396004: Make observable transform a barback transform.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/codegen/lib/codegen.dart

Issue 22396004: Make observable transform a barback transform. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 library reexport_core_helper;	5 library codegen;
	Jennifer Messerly 2013/08/09 05:44:03 IMHO -- this is way too generic of a name given th IMHO -- this is way too generic of a name given the current content of this package. Since there isn't much here, could we merge this into another pkg? Could they plausibly be helpers inside source_maps? Or analyzer, since it's concerned with analysis and code transformation (refactorings etc)? Siggi Cherem (dart-lang) 2013/08/09 22:09:09 Ok - refactored things a bit. These two helpers mo Show quoted text On 2013/08/09 05:44:03, John Messerly wrote: > IMHO -- this is way too generic of a name given the current content of this > package. > > Since there isn't much here, could we merge this into another pkg? > Could they plausibly be helpers inside source_maps? Or analyzer, since it's > concerned with analysis and code transformation (refactorings etc)? Ok - refactored things a bit. These two helpers moved to source_maps. but code-printer is now more generic (no 'Declarations'). I moved the tests there too and added a couple tests for NestedPrinter. We might want to rename 'source_maps' though. Ideas welcomed :-)
6	6

7 export 'dart:core';	7 export 'printer.dart';

8	8 export 'refactor.dart';

OLD	NEW

« pkg/barback/pubspec.yaml ('K') | « pkg/barback/pubspec.yaml ('k') | pkg/codegen/lib/printer.dart » ('j') | pkg/codegen/lib/refactor.dart » ('J')