Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: Source/devtools/front_end/DOMStorage.js

Issue 22396002: function storageForId() should be used in _domStorageItemUpdated instead of DOMStorageModel._storag… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Nokia Inc. All rights reserved. 2 * Copyright (C) 2008 Nokia Inc. All rights reserved.
3 * Copyright (C) 2013 Samsung Electronics. All rights reserved. 3 * Copyright (C) 2013 Samsung Electronics. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 }, 424 },
425 425
426 /** 426 /**
427 * @param {DOMStorageAgent.StorageId} storageId 427 * @param {DOMStorageAgent.StorageId} storageId
428 * @param {string} key 428 * @param {string} key
429 * @param {string} oldValue 429 * @param {string} oldValue
430 * @param {string} newValue 430 * @param {string} newValue
431 */ 431 */
432 _domStorageItemUpdated: function(storageId, key, oldValue, newValue) 432 _domStorageItemUpdated: function(storageId, key, oldValue, newValue)
433 { 433 {
434 var domStorage = this._storages[storageId]; 434 var domStorage = this.storageForId(storageId);
apavlov 2013/08/06 09:31:18 Can you add a test for this?
aandrey 2013/08/06 10:55:19 this should have been caught by the jscompiler. pl
435 var storageData = { 435 var storageData = {
436 storage: domStorage, 436 storage: domStorage,
437 key: key, 437 key: key,
438 oldValue: oldValue, 438 oldValue: oldValue,
439 newValue: newValue 439 newValue: newValue
440 }; 440 };
441 this.dispatchEventToListeners(WebInspector.DOMStorageModel.Events.DOMSto rageItemUpdated, storageData); 441 this.dispatchEventToListeners(WebInspector.DOMStorageModel.Events.DOMSto rageItemUpdated, storageData);
442 }, 442 },
443 443
444 /** 444 /**
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 domStorageItemUpdated: function(storageId, key, oldValue, newValue) 512 domStorageItemUpdated: function(storageId, key, oldValue, newValue)
513 { 513 {
514 this._model._domStorageItemUpdated(storageId, key, oldValue, newValue); 514 this._model._domStorageItemUpdated(storageId, key, oldValue, newValue);
515 }, 515 },
516 } 516 }
517 517
518 /** 518 /**
519 * @type {WebInspector.DOMStorageModel} 519 * @type {WebInspector.DOMStorageModel}
520 */ 520 */
521 WebInspector.domStorageModel = null; 521 WebInspector.domStorageModel = null;
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698