function storageForId() should be used in _domStorageItemUpdated instead of DOMStorageModel._storag…

function storageForId() should be used in _domStorageItemUpdated instead of DOMStorageModel._storages[]

The commit with commit hash: "17af239b44a9a02b2d6b02f9f5aaaf6cb7b4ce1f" 
(https://bugs.webkit.org/show_bug.cgi?id=109572) missed to use the function storageForId
instead of DOMStorageModel._storages[] due to which the update is not triggered.

R=apavlov

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155616

[apavlov, 2013-08-06 09:31:17]

lgtm with a comment

https://codereview.chromium.org/22396002/diff/1/Source/devtools/front_end/DOM...
File Source/devtools/front_end/DOMStorage.js (right):

https://codereview.chromium.org/22396002/diff/1/Source/devtools/front_end/DOM...
Source/devtools/front_end/DOMStorage.js:434: var domStorage =
this.storageForId(storageId);
Can you add a test for this?

[apavlov, 2013-08-06 10:08:31]

nice!

[commit-bot: I haz the power, 2013-08-06 10:08:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/22396002/6001

[aandrey, 2013-08-06 10:55:19]

https://codereview.chromium.org/22396002/diff/1/Source/devtools/front_end/DOM...
File Source/devtools/front_end/DOMStorage.js (right):

https://codereview.chromium.org/22396002/diff/1/Source/devtools/front_end/DOM...
Source/devtools/front_end/DOMStorage.js:434: var domStorage =
this.storageForId(storageId);
On 2013/08/06 09:31:18, apavlov wrote:
> Can you add a test for this?

this should have been caught by the jscompiler. plz declare in the constructor:

  /** @type {!Object.<string, !WebInspector.DOMStorage>} */
  this._storages = {};

[vivekg_samsung, 2013-08-06 11:14:47]

On 2013/08/06 10:55:19, aandrey wrote:
>
https://codereview.chromium.org/22396002/diff/1/Source/devtools/front_end/DOM...
> File Source/devtools/front_end/DOMStorage.js (right):
> 
>
https://codereview.chromium.org/22396002/diff/1/Source/devtools/front_end/DOM...
> Source/devtools/front_end/DOMStorage.js:434: var domStorage =
> this.storageForId(storageId);
> On 2013/08/06 09:31:18, apavlov wrote:
> > Can you add a test for this?
> 
> this should have been caught by the jscompiler. plz declare in the
constructor:
> 
>   /** @type {!Object.<string, !WebInspector.DOMStorage>} */
>   this._storages = {};

done.

[commit-bot: I haz the power, 2013-08-06 11:38:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/22396002/2002

[commit-bot: I haz the power, 2013-08-06 13:00:20]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-08-06 13:02:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/22396002/2002

[commit-bot: I haz the power, 2013-08-06 15:52:23]

Change committed as 155616