Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2239563002: Remove remaining dependency on test_runner from components. (Closed)

Created:
4 years, 4 months ago by jam
Modified:
4 years, 4 months ago
Reviewers:
eroman
CC:
chromium-reviews, blundell+watchlist_chromium.org, droger+watchlist_chromium.org, sdefresne+watchlist_chromium.org, mlamouri+watch-test-runner_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remaining dependency on test_runner from components. BUG=634326 Committed: https://crrev.com/7ffe5e2e56828cdfa90866f10c863c4dd8d49f7b Cr-Commit-Position: refs/heads/master@{#411500}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -37 lines) Patch
M components/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/test_common.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/test_runner/test_common.cc View 1 3 chunks +1 line, -22 lines 0 comments Download
M components/webcrypto/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M components/webcrypto/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/webcrypto/fuzzer_support.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
jam
4 years, 4 months ago (2016-08-11 16:59:56 UTC) #10
eroman
lgtm https://codereview.chromium.org/2239563002/diff/20001/components/webcrypto/fuzzer_support.cc File components/webcrypto/fuzzer_support.cc (right): https://codereview.chromium.org/2239563002/diff/20001/components/webcrypto/fuzzer_support.cc#newcode25 components/webcrypto/fuzzer_support.cc:25: // EnsureBlinkInitialized() depends on the command line singleton ...
4 years, 4 months ago (2016-08-11 17:55:36 UTC) #11
jam
https://codereview.chromium.org/2239563002/diff/20001/components/webcrypto/fuzzer_support.cc File components/webcrypto/fuzzer_support.cc (right): https://codereview.chromium.org/2239563002/diff/20001/components/webcrypto/fuzzer_support.cc#newcode25 components/webcrypto/fuzzer_support.cc:25: // EnsureBlinkInitialized() depends on the command line singleton being ...
4 years, 4 months ago (2016-08-11 19:12:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239563002/40001
4 years, 4 months ago (2016-08-11 19:13:42 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/276329)
4 years, 4 months ago (2016-08-11 21:50:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239563002/40001
4 years, 4 months ago (2016-08-11 23:49:40 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-12 01:05:26 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 01:07:32 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7ffe5e2e56828cdfa90866f10c863c4dd8d49f7b
Cr-Commit-Position: refs/heads/master@{#411500}

Powered by Google App Engine
This is Rietveld 408576698