Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3458)

Unified Diff: chrome/BUILD.gn

Issue 2239533002: Don't disable incremental linking for chrome.dll in component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 4505493152be345f94feebc57fcac810b4acff8e..bf736d929ed34f1e5935ef2066d23b70de952293 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -282,9 +282,6 @@ if (is_win) {
# This target is a forwarding target to compile the necessary DLLs used
# by Chrome.
group("chrome_dll") {
- # TODO(GYP) support incremental_chrome_dll on Windows for faster links in
- # developer component builds. When that's supported, this target will need
- # to become more complicated.
data_deps = [
":main_dll",
]
@@ -353,10 +350,13 @@ if (is_win) {
"/DELAYLOAD:wsock32.dll",
]
- # This is a large module that can't do incremental linking in some cases.
- configs -= [ "//build/config/win:default_incremental_linking" ]
- configs +=
- [ "//build/config/win:default_large_module_incremental_linking" ]
+ if (!is_component_build) {
+ # This is a large module that can't do incremental linking in some
+ # cases.
+ configs -= [ "//build/config/win:default_incremental_linking" ]
+ configs +=
+ [ "//build/config/win:default_large_module_incremental_linking" ]
+ }
Nico 2017/08/16 20:07:26 This basically reverts https://codereview.chromium
scottmg 2017/08/16 20:22:57 Yeah.
}
if (use_aura) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698