chromeos: Don't spam logs with update_engine D-Bus errors.

chromeos: Don't spam logs with update_engine D-Bus errors.

Make UpdateEngineClientImpl wait to get update_engine's
initial status until D-Bus has notified us that it's
available.

BUG=636554
Committed: https://crrev.com/501900f5a00aec0af5b5e9ed62ae933aead7fffa
Cr-Commit-Position: refs/heads/master@{#411190}

[Daniel Erat, 2016-08-10 21:56:18]

derat@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Daniel Erat, 2016-08-10 21:56:19]

https://codereview.chromium.org/2239513002/diff/1/chromeos/dbus/update_engine...
File chromeos/dbus/update_engine_client.cc (left):

https://codereview.chromium.org/2239513002/diff/1/chromeos/dbus/update_engine...
chromeos/dbus/update_engine_client.cc:229: // brightness level in Chrome as it
will make things less reliable.
hmm, i wonder where this code was copy-and-pasted from... :-P

[stevenjb, 2016-08-10 22:24:22]

lgtm

https://codereview.chromium.org/2239513002/diff/1/chromeos/dbus/update_engine...
File chromeos/dbus/update_engine_client.cc (left):

https://codereview.chromium.org/2239513002/diff/1/chromeos/dbus/update_engine...
chromeos/dbus/update_engine_client.cc:229: // brightness level in Chrome as it
will make things less reliable.
On 2016/08/10 21:56:18, Daniel Erat wrote:
> hmm, i wonder where this code was copy-and-pasted from... :-P

Heh.

[Daniel Erat, 2016-08-10 22:49:08]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-08-10 22:50:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 23:52:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-10 23:54:13]

Description was changed from

==========
chromeos: Don't spam logs with update_engine D-Bus errors.

Make UpdateEngineClientImpl wait to get update_engine's
initial status until D-Bus has notified us that it's
available.

BUG=636554
==========

to

==========
chromeos: Don't spam logs with update_engine D-Bus errors.

Make UpdateEngineClientImpl wait to get update_engine's
initial status until D-Bus has notified us that it's
available.

BUG=636554

Committed: https://crrev.com/501900f5a00aec0af5b5e9ed62ae933aead7fffa
Cr-Commit-Position: refs/heads/master@{#411190}
==========

[commit-bot: I haz the power, 2016-08-10 23:54:14]

Patchset 1 (id:??) landed as
https://crrev.com/501900f5a00aec0af5b5e9ed62ae933aead7fffa
Cr-Commit-Position: refs/heads/master@{#411190}

[Daniel Erat, 2016-08-11 01:13:50]

https://codereview.chromium.org/2239513002/diff/1/chromeos/dbus/update_engine...
File chromeos/dbus/update_engine_client.cc (right):

https://codereview.chromium.org/2239513002/diff/1/chromeos/dbus/update_engine...
chromeos/dbus/update_engine_client.cc:239: void OnProxyAvailabilityChanged(bool
service_is_available) {
i misunderstood how WaitForServiceToBeAvailable actually works. this is only
called once; i should probably rename this method to something like
OnProxyAvailable (although it can also be called with a false argument in the
unlikely event of an internal error in our d-bus library).