Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2239443004: Add more unittesting for GeometryMapper+PaintPropertyTrreBuilde integration. (Closed)

Created:
4 years, 4 months ago by chrishtr
Modified:
4 years, 4 months ago
Reviewers:
Xianzhu, szager1
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more unittesting for GeometryMapper+PaintPropertyTrreBuilde integration. BUG=611379 Committed: https://crrev.com/17052eb167de3d772f408039bef7d0fffbaec6a8 Cr-Commit-Position: refs/heads/master@{#411332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -125 lines) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 40 chunks +251 lines, -122 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.h View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/test_data/perspective.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/test_data/position-and-scroll.html View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/test_data/relative-position-inline.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
chrishtr
I added widths and heights to elements as needed, to avoid useless testing of mapping ...
4 years, 4 months ago (2016-08-11 00:48:02 UTC) #3
Xianzhu
lgtm
4 years, 4 months ago (2016-08-11 01:25:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239443004/1
4 years, 4 months ago (2016-08-11 15:10:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 15:13:37 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/17052eb167de3d772f408039bef7d0fffbaec6a8 Cr-Commit-Position: refs/heads/master@{#411332}
4 years, 4 months ago (2016-08-11 15:15:13 UTC) #13
szager1
4 years, 4 months ago (2016-08-16 23:07:18 UTC) #15
Message was sent while issue was closed. 
FYI, adding the CHECK_VISUAL_RECT calls is problematic:

https://bugs.chromium.org/p/chromium/issues/detail?id=638386

I came across this while adding root layer scrolling support to
PaintPropertyTreeBuilder.  With my changes, the layout invalidation rects in
some of these tests are better (i.e. they are accurate but smaller), so they
fail these CHECK_VISUAL_RECT calls.

Powered by Google App Engine
This is Rietveld 408576698