[MD User Menu] Removed the tooltips for profile buttons

[MD User Menu] Removed the tooltips for profile buttons

Removing the tooltips for the profile switching buttons in the MD user
menu. Tooltips used to show up for long profile names.
The design rationale is to not have native tooltips for MD UI.

BUG=615893
Committed: https://crrev.com/763815b9496d4c7bea3354e05e3d5c0969d70ba0
Cr-Commit-Position: refs/heads/master@{#411639}

[Jane, 2016-08-10 22:57:42]

janeliulwq@google.com changed reviewers:
+ groby@chromium.org, sky@chromium.org

[Jane, 2016-08-10 22:57:42]

janeliulwq@google.com changed required reviewers:
+ groby@chromium.org, sky@chromium.org

[Jane, 2016-08-10 22:57:43]

Hi groby@ and sky@, would you take a look at this small change on mac and linux
respectively please. Thanks!

[sky, 2016-08-11 03:25:35]

https://codereview.chromium.org/2239443003/diff/1/chrome/browser/ui/views/pro...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/2239443003/diff/1/chrome/browser/ui/views/pro...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:203:
label()->SetHandlesTooltips(false);
The other option is to not set a tooltip. Not setting a tooltip seems a bit less
obscure than calling this after the fact. Is there a reason you need to set the
tooltip for the md case?

[Jane, 2016-08-11 14:59:04]

janeliulwq@google.com changed reviewers:
- groby@chromium.org

[Jane, 2016-08-11 14:59:04]

janeliulwq@google.com changed required reviewers:
- groby@chromium.org

[Jane, 2016-08-11 14:59:04]

https://codereview.chromium.org/2239443003/diff/1/chrome/browser/ui/views/pro...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/2239443003/diff/1/chrome/browser/ui/views/pro...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:203:
label()->SetHandlesTooltips(false);
On 2016/08/11 03:25:35, sky wrote:
> The other option is to not set a tooltip. Not setting a tooltip seems a bit
less
> obscure than calling this after the fact. Is there a reason you need to set
the
> tooltip for the md case?

I don't need to set the tooltip for the MD case, and I agree that it's better to
just not set the tooltip. But I couldn't find a way to do it - it seems that
LabelButton's Label controls the tooltip text and sets it to be the full text of
the label by default
(https://cs.chromium.org/chromium/src/ui/views/controls/label.cc?sq=package:ch...).
Am I missing something? Thanks!

[sky, 2016-08-11 20:24:21]

You're right. LGTM

[Jane, 2016-08-11 20:26:34]

janeliulwq@google.com changed reviewers:
+ groby@chromium.org

[Jane, 2016-08-11 20:26:34]

janeliulwq@google.com changed required reviewers:
+ groby@chromium.org

[Jane, 2016-08-11 20:26:35]

Hi Rachel, mac part please, thanks!

[groby-ooo-7-16, 2016-08-11 22:12:27]

lgtm

[Jane, 2016-08-12 13:33:05]

The CQ bit was checked by janeliulwq@google.com

[commit-bot: I haz the power, 2016-08-12 13:33:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 14:08:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 14:11:49]

Description was changed from

==========
[MD User Menu] Removed the tooltips for profile buttons

Removing the tooltips for the profile switching buttons in the MD user
menu. Tooltips used to show up for long profile names.
The design rationale is to not have native tooltips for MD UI.

BUG=615893
==========

to

==========
[MD User Menu] Removed the tooltips for profile buttons

Removing the tooltips for the profile switching buttons in the MD user
menu. Tooltips used to show up for long profile names.
The design rationale is to not have native tooltips for MD UI.

BUG=615893

Committed: https://crrev.com/763815b9496d4c7bea3354e05e3d5c0969d70ba0
Cr-Commit-Position: refs/heads/master@{#411639}
==========

[commit-bot: I haz the power, 2016-08-12 14:11:50]

Patchset 1 (id:??) landed as
https://crrev.com/763815b9496d4c7bea3354e05e3d5c0969d70ba0
Cr-Commit-Position: refs/heads/master@{#411639}