android_make now exactly the same as android_ninja

platform_tools/android/bin/android_make

Index: platform_tools/android/bin/android_make
diff --git a/platform_tools/android/bin/android_make b/platform_tools/android/bin/android_make
index a5f5268931010c134cbf19a6fc15888ef2bb41ce..c12ec3f35273e99a57f731aebc6bfdefd3a11443 100755
--- a/platform_tools/android/bin/android_make
+++ b/platform_tools/android/bin/android_make
@@ -1,8 +1,5 @@
 #!/bin/bash
 
-# Fail-fast if anything in the script fails.
-set -e
-
 # Remove any existing .android_config file before running android_setup. If we
 # did not remove this now then we would build for whatever device type was
 # listed in the .android_config instead of the default device type.
@@ -11,14 +8,11 @@ rm -f .android_config
 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 source $SCRIPT_DIR/android_setup.sh
 

[djsollen, 2014/04/03 15:02:52]

I think having set -e after line 9 is a good idea.

[epoger, 2014/04/03 15:06:01]

Done.

-if [ $(basename $0) = "android_make" ]; then
-    GYP_GENERATORS=make-android make ${APP_ARGS[@]}
-else
-    GYP_GENERATORS=ninja-android ./gyp_skia
-    OUT=$SKIA_OUT/${BUILDTYPE-Debug}   # Defaults to Debug if BUILDTYPE isn't set.
-    ninja -C $OUT ${APP_ARGS[@]}
-    ln -sf lib $OUT/lib.target         # android_run_skia looks in lib.target; ninja writes to lib.
-fi
+GYP_GENERATORS=ninja-android ./gyp_skia
+OUT=$SKIA_OUT/${BUILDTYPE-Debug}   # Defaults to Debug if BUILDTYPE isn't set.
+ninja -C $OUT ${APP_ARGS[@]}
+ln -sf lib $OUT/lib.target         # android_run_skia looks in lib.target; ninja writes to lib.
+                                   # TODO(mtklein): change android_run_skia
 
 # Write the device id into the .android_config file.  This tells
 # android_run_skia the last build we completed.