Don't mark a history navigation as in page in a new renderer process.

Don't mark a history navigation as in page in a new renderer process.

Blink won't realize that the page needs to be loaded from scratch and
will stay in-page on the initial blank page.  This became a problem
when moving the in-page determination to the browser process, where
we need to check whether the renderer process has a committed page
or not.

BUG=635403
TEST=Ctrl+back in page (see bug comment 4 for repro steps)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/5413169e62dc4c20d31e1afaea680f943bbe085c
Cr-Commit-Position: refs/heads/master@{#411712}

[Charlie Reis, 2016-08-12 16:57:24]

Description was changed from

==========
Don't mark a history navigation as in page in a new renderer process.

Blink won't realize that the page needs to be loaded from scratch and
will stay in-page on the initial blank page.  This became a problem
when moving the in-page determination to the browser process, where
we need to check whether the renderer process has a committed page
or not.

BUG=635403
TEST=Ctrl+back in page (see bug comment 4 for repro steps)
==========

to

==========
Don't mark a history navigation as in page in a new renderer process.

Blink won't realize that the page needs to be loaded from scratch and
will stay in-page on the initial blank page.  This became a problem
when moving the in-page determination to the browser process, where
we need to check whether the renderer process has a committed page
or not.

BUG=635403
TEST=Ctrl+back in page (see bug comment 4 for repro steps)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Charlie Reis, 2016-08-12 16:57:29]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 16:57:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2016-08-12 16:59:31]

creis@chromium.org changed reviewers:
+ nasko@chromium.org

[Charlie Reis, 2016-08-12 16:59:32]

Nasko, can you take a look?

The renderer-side check is just to be safe against other state confusion bugs. 
Either fix seems sufficient for these specific repro steps.

I think we can probably add a DSN check to the renderer-side check in a followup
CL, which might possibly help with the origin mismatch cases.

[nasko, 2016-08-12 17:15:43]

LGTM

[Charlie Reis, 2016-08-12 17:33:37]

The CQ bit was unchecked by creis@chromium.org

[Charlie Reis, 2016-08-12 17:33:42]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-08-12 17:33:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 18:32:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 18:35:34]

Description was changed from

==========
Don't mark a history navigation as in page in a new renderer process.

Blink won't realize that the page needs to be loaded from scratch and
will stay in-page on the initial blank page.  This became a problem
when moving the in-page determination to the browser process, where
we need to check whether the renderer process has a committed page
or not.

BUG=635403
TEST=Ctrl+back in page (see bug comment 4 for repro steps)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Don't mark a history navigation as in page in a new renderer process.

Blink won't realize that the page needs to be loaded from scratch and
will stay in-page on the initial blank page.  This became a problem
when moving the in-page determination to the browser process, where
we need to check whether the renderer process has a committed page
or not.

BUG=635403
TEST=Ctrl+back in page (see bug comment 4 for repro steps)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/5413169e62dc4c20d31e1afaea680f943bbe085c
Cr-Commit-Position: refs/heads/master@{#411712}
==========

[commit-bot: I haz the power, 2016-08-12 18:35:35]

Patchset 1 (id:??) landed as
https://crrev.com/5413169e62dc4c20d31e1afaea680f943bbe085c
Cr-Commit-Position: refs/heads/master@{#411712}