components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc - Issue 2239383002: GN proto_libary refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc

Issue 2239383002: GN proto_libary refactoring. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo in test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc

diff --git a/components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc b/components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc

index 718201503a545d972e4472b5f01e410b7503ee4d..69f68a0c2d5ff5eefa441cc27f8fe2547c317741 100644

--- a/components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc

+++ b/components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc

@@ -209,7 +209,7 @@ class GeneratorJob {

"// //components/tracing/tools/proto_zero_plugin.\n";

std::string guard = package_ + "_" + source_->name() + "_H_";

UpperString(&guard);

- StripString(&guard, ".-", '_');

+ StripString(&guard, ".-/\\", '_');

stub_h_->Print(

"$greeting$\n"