Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 223933002: Adds 192kHz support for WebRTC capturing (Closed)

Created:
6 years, 8 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Adds 192kHz support for WebRTC capturing. BUG=none TEST=WebRTC demos on Windows using a capture device which supports 192kHz. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261441

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/renderer/media/webrtc_audio_capturer.cc View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
henrika (OOO until Aug 14)
Shijing, please check.
6 years, 8 months ago (2014-04-03 14:07:48 UTC) #1
no longer working on chromium
Henrik, could you please run chrome with --enable-audio-track-processing and try ML in studio mode, then ...
6 years, 8 months ago (2014-04-03 14:12:39 UTC) #2
no longer working on chromium
discussed offline, lgtm
6 years, 8 months ago (2014-04-03 14:16:55 UTC) #3
henrika (OOO until Aug 14)
The CQ bit was checked by henrika@chromium.org
6 years, 8 months ago (2014-04-03 14:17:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/223933002/1
6 years, 8 months ago (2014-04-03 14:18:45 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 16:29:44 UTC) #6
Message was sent while issue was closed.
Change committed as 261441

Powered by Google App Engine
This is Rietveld 408576698