Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2239303004: Normalize paths in PhysicalResourceProvider.getFile()/getFolder(). (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Normalize paths in PhysicalResourceProvider.getFile()/getFolder(). R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9f187f3df5ecc0cd67f2091af9d8af7e820e303a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +8 lines, -2 lines 2 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 3 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 4 months ago (2016-08-12 17:33:40 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2239303004/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart File pkg/analyzer/lib/file_system/physical_file_system.dart (right): https://codereview.chromium.org/2239303004/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart#newcode76 pkg/analyzer/lib/file_system/physical_file_system.dart:76: path = normalize(path); Should this be "pathContext.normalize()"?
4 years, 4 months ago (2016-08-12 17:43:33 UTC) #2
scheglov
https://codereview.chromium.org/2239303004/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart File pkg/analyzer/lib/file_system/physical_file_system.dart (right): https://codereview.chromium.org/2239303004/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart#newcode76 pkg/analyzer/lib/file_system/physical_file_system.dart:76: path = normalize(path); On 2016/08/12 17:43:33, Brian Wilkerson wrote: ...
4 years, 4 months ago (2016-08-12 18:02:50 UTC) #3
scheglov
4 years, 4 months ago (2016-08-12 18:04:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9f187f3df5ecc0cd67f2091af9d8af7e820e303a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698