Issue 2239303003: Remove SandboxBlocksModals runtime flag (status=stable)

Issue 2239303003: Remove SandboxBlocksModals runtime flag (status=stable) (Closed)

Created:
4 years, 4 months ago by rwlbuis

Modified:
4 years, 3 months ago

Reviewers:
Mike West

CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, sof

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove SandboxBlocksModals runtime flag (status=stable) BUG=402536 Committed: https://crrev.com/19c120710a71408ddd41e19e13d778c63f5a70b7 Cr-Commit-Position: refs/heads/master@{#415635}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -18 lines)			Patch
M	third_party/WebKit/Source/core/dom/SandboxFlags.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp	View	4 chunks	+8 lines, -16 lines	0 comments	Download
M	third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 12 (6 generated)

Mike West

LGTM, thanks. Sorry for the delay; I've been OOO for a while. :/

4 years, 3 months ago (2016-08-31 13:26:42 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239303003/1

4 years, 3 months ago (2016-08-31 13:32:10 UTC) #7

rwlbuis

On 2016/08/31 13:26:42, Mike West (OOO until 29th) wrote: > LGTM, thanks. > > Sorry ...

4 years, 3 months ago (2016-08-31 13:36:44 UTC) #8

commit-bot: I haz the power

4 years, 3 months ago (2016-08-31 15:16:18 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/19c120710a71408ddd41e19e13d778c63f5a70b7
Cr-Commit-Position: refs/heads/master@{#415635}