Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2239293003: Disable VirtualTimeTest* on Andorid (Closed)

Created:
4 years, 4 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 4 months ago
Reviewers:
Sami
CC:
chromium-reviews, blink-reviews, kinuko+watch, kolos1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable VirtualTimeTest* on Andorid These tests are failing on Android. We don't actually need this code to run there currently, so lets disable them and figure out later why they fail there. (My suspicion is something is different about the android gtest harness which causes virtual time to break things) BUG=633321 Committed: https://crrev.com/50aaa9cf939631691a4a0dfde16f1fc429db7b1b Cr-Commit-Position: refs/heads/master@{#411675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp View 4 chunks +28 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alex clarke (OOO till 29th)
4 years, 4 months ago (2016-08-12 14:28:23 UTC) #2
Sami
lgtm.
4 years, 4 months ago (2016-08-12 14:31:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239293003/1
4 years, 4 months ago (2016-08-12 14:32:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 16:45:59 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 16:47:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50aaa9cf939631691a4a0dfde16f1fc429db7b1b
Cr-Commit-Position: refs/heads/master@{#411675}

Powered by Google App Engine
This is Rietveld 408576698