Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: content/browser/ssl/ssl_manager.cc

Issue 2239273002: Don't use SSLStatus from FrameHostMsg_DidCommitProvisionalLoad and instead cache it on the browser … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: slight cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/ssl/ssl_manager.cc
diff --git a/content/browser/ssl/ssl_manager.cc b/content/browser/ssl/ssl_manager.cc
index f50efb23689b14011ffb375f25577844c4376c0c..9d3cbc5d4ca12e0eed4a12f8bef2c35b92ce1915 100644
--- a/content/browser/ssl/ssl_manager.cc
+++ b/content/browser/ssl/ssl_manager.cc
@@ -144,16 +144,8 @@ SSLManager::~SSLManager() {
}
void SSLManager::DidCommitProvisionalLoad(const LoadCommittedDetails& details) {
+ // TODO(jam): remove details.ssl_status
NavigationEntryImpl* entry = controller_->GetLastCommittedEntry();
-
- if (details.is_main_frame) {
- if (entry) {
- // We may not have an entry if this is a navigation to an initial blank
- // page. Add the new data we have.
- entry->GetSSL() = details.ssl_status;
- }
- }
-
policy()->UpdateEntry(entry, controller_->delegate()->GetWebContents());
// Always notify the WebContents that the SSL state changed when a
// load is committed, in case the active navigation entry has changed.
« content/browser/loader/resource_loader.cc ('K') | « content/browser/loader/resource_loader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698