Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Unified Diff: content/browser/loader/resource_loader.cc

Issue 2239273002: Don't use SSLStatus from FrameHostMsg_DidCommitProvisionalLoad and instead cache it on the browser … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_loader.cc
diff --git a/content/browser/loader/resource_loader.cc b/content/browser/loader/resource_loader.cc
index d9a3b8f4ee27c37eeeec7c42877664cfab996d76..b369be9c3e25f96dfaf6449848b63d597c24d339 100644
--- a/content/browser/loader/resource_loader.cc
+++ b/content/browser/loader/resource_loader.cc
@@ -52,19 +52,6 @@ using base::TimeTicks;
namespace content {
namespace {
-void GetSSLStatusForRequest(const GURL& url,
- const net::SSLInfo& ssl_info,
- int child_id,
- CertStore* cert_store,
- SSLStatus* ssl_status) {
- DCHECK(ssl_info.cert);
- int cert_id = cert_store->StoreCert(ssl_info.cert.get(), child_id);
-
- *ssl_status = SSLStatus(SSLPolicy::GetSecurityStyleForResource(
- url, cert_id, ssl_info.cert_status),
- cert_id, ssl_info);
-}
-
void PopulateResourceResponse(ResourceRequestInfoImpl* info,
net::URLRequest* request,
CertStore* cert_store,
@@ -113,9 +100,10 @@ void PopulateResourceResponse(ResourceRequestInfoImpl* info,
request->GetLoadTimingInfo(&response->head.load_timing);
if (request->ssl_info().cert.get()) {
- SSLStatus ssl_status;
- GetSSLStatusForRequest(request->url(), request->ssl_info(),
- info->GetChildID(), cert_store, &ssl_status);
+ SSLStatus ssl_status;
+ ResourceLoader::GetSSLStatusForRequest(
+ request->url(), request->ssl_info(), info->GetChildID(),
+ cert_store, &ssl_status);
response->head.security_info = SerializeSecurityInfo(ssl_status);
response->head.has_major_certificate_errors =
net::IsCertStatusError(ssl_status.cert_status) &&
@@ -138,6 +126,19 @@ void PopulateResourceResponse(ResourceRequestInfoImpl* info,
} // namespace
+void ResourceLoader::GetSSLStatusForRequest(const GURL& url,
+ const net::SSLInfo& ssl_info,
+ int child_id,
+ CertStore* cert_store,
+ SSLStatus* ssl_status) {
+ DCHECK(ssl_info.cert);
+ int cert_id = cert_store->StoreCert(ssl_info.cert.get(), child_id);
+
+ *ssl_status = SSLStatus(SSLPolicy::GetSecurityStyleForResource(
+ url, cert_id, ssl_info.cert_status),
+ cert_id, ssl_info);
+}
+
ResourceLoader::ResourceLoader(std::unique_ptr<net::URLRequest> request,
std::unique_ptr<ResourceHandler> handler,
CertStore* cert_store,

Powered by Google App Engine
This is Rietveld 408576698