Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Side by Side Diff: content/public/browser/navigation_details.h

Issue 2239273002: Don't use SSLStatus from FrameHostMsg_DidCommitProvisionalLoad and instead cache it on the browser … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_DETAILS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_DETAILS_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_DETAILS_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_DETAILS_H_
7 7
8 #include <string> 8 #include <string>
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 #include "content/public/browser/navigation_type.h" 10 #include "content/public/browser/navigation_type.h"
11 #include "content/public/common/ssl_status.h"
12 #include "url/gurl.h" 11 #include "url/gurl.h"
13 12
14 namespace content { 13 namespace content {
15 14
16 class NavigationEntry; 15 class NavigationEntry;
17 16
18 // Provides the details for a NOTIFICATION_NAV_ENTRY_COMMITTED notification. 17 // Provides the details for a NOTIFICATION_NAV_ENTRY_COMMITTED notification.
19 // TODO(brettw) this mostly duplicates ProvisionalLoadDetails, it would be 18 // TODO(brettw) this mostly duplicates ProvisionalLoadDetails, it would be
20 // nice to unify these somehow. 19 // nice to unify these somehow.
21 struct CONTENT_EXPORT LoadCommittedDetails { 20 struct CONTENT_EXPORT LoadCommittedDetails {
(...skipping 23 matching lines...) Expand all
45 bool did_replace_entry; 44 bool did_replace_entry;
46 45
47 // True if the navigation was in-page. This means that the active entry's 46 // True if the navigation was in-page. This means that the active entry's
48 // URL and the |previous_url| are the same except for reference fragments. 47 // URL and the |previous_url| are the same except for reference fragments.
49 bool is_in_page; 48 bool is_in_page;
50 49
51 // True when the main frame was navigated. False means the navigation was a 50 // True when the main frame was navigated. False means the navigation was a
52 // sub-frame. 51 // sub-frame.
53 bool is_main_frame; 52 bool is_main_frame;
54 53
55 // When the committed load is a web page from the renderer, this contains
56 // the security state if the page is secure.
57 // See FrameHostMsg_DidCommitProvisionalLoad_Params.security_info, where it
58 // comes from, after being deserialized with
59 // SSLManager::DeserializeSecurityInfo.
60 SSLStatus ssl_status;
61
62 // Returns whether the main frame navigated to a different page (e.g., not 54 // Returns whether the main frame navigated to a different page (e.g., not
63 // scrolling to a fragment inside the current page). We often need this logic 55 // scrolling to a fragment inside the current page). We often need this logic
64 // for showing or hiding something. 56 // for showing or hiding something.
65 bool is_navigation_to_different_page() const { 57 bool is_navigation_to_different_page() const {
66 return is_main_frame && !is_in_page; 58 return is_main_frame && !is_in_page;
67 } 59 }
68 60
69 // The HTTP status code for this entry.. 61 // The HTTP status code for this entry..
70 int http_status_code; 62 int http_status_code;
71 }; 63 };
(...skipping 13 matching lines...) Expand all
85 // count items were removed from the back of the list. 77 // count items were removed from the back of the list.
86 bool from_front; 78 bool from_front;
87 79
88 // Number of items removed. 80 // Number of items removed.
89 int count; 81 int count;
90 }; 82 };
91 83
92 } // namespace content 84 } // namespace content
93 85
94 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_DETAILS_H_ 86 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_DETAILS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698