Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2239233004: Revert of Work around simctl error when moving from Xcode 7 to Xcode 8. (Closed)

Created:
4 years, 4 months ago by justincohen
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Work around simctl error when moving from Xcode 7 to Xcode 8. (patchset #1 id:1 of https://codereview.chromium.org/2226963003/ ) Reason for revert: This is causing a timeout where we no longer run Xcode 7. Try removing it. Original issue's description: > Work around simctl error when moving from Xcode 7 to Xcode 8. > > BUG= > TBR=rohitrao@chromium.org > > Committed: https://crrev.com/83610f5d8af84ad969d47824120324cec2bcf8e2 > Cr-Commit-Position: refs/heads/master@{#410636} TBR=stkhapugin@chromium.org,rohitrao@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= NOTRY=true Committed: https://crrev.com/eaca3e2d0a45942d4ad0c24ee20cd180d4820fd1 Cr-Commit-Position: refs/heads/master@{#411784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M testing/iossim/iossim.mm View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
justincohen
Created Revert of Work around simctl error when moving from Xcode 7 to Xcode 8.
4 years, 4 months ago (2016-08-12 21:33:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239233004/1
4 years, 4 months ago (2016-08-12 21:34:18 UTC) #4
rohitrao (ping after 24h)
LGTM
4 years, 4 months ago (2016-08-12 21:36:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239233004/1
4 years, 4 months ago (2016-08-12 21:38:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 21:43:01 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/eaca3e2d0a45942d4ad0c24ee20cd180d4820fd1 Cr-Commit-Position: refs/heads/master@{#411784}
4 years, 4 months ago (2016-08-12 21:45:01 UTC) #13
justincohen
4 years, 4 months ago (2016-08-13 01:58:10 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2237313005/ by justincohen@chromium.org.

The reason for reverting is: Turns out the correct fix is here, and this wasn't
causing the issue.  Putting back this code since it still has some value if a
swarming bot is testing Xcode 7 code.

Other fix here: https://codereview.chromium.org/2240373002/.

Powered by Google App Engine
This is Rietveld 408576698