ash/common/wm/overview/scoped_overview_animation_settings.h - Issue 2239233002: [ash-md] Fades overview header in and out

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/common/wm/overview/scoped_overview_animation_settings.h

Issue 2239233002: [ash-md] Fades overview header in and out (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [ash-md] Fades overview header in and out (more tests) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ash/common/wm/overview/overview_animation_type.h ('k') | ash/common/wm/overview/scoped_transform_overview_window.h » ('j') | ash/common/wm/overview/scoped_transform_overview_window.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ASH_COMMON_WM_OVERVIEW_SCOPED_OVERVIEW_ANIMATION_SETTINGS_H_	5 #ifndef ASH_COMMON_WM_OVERVIEW_SCOPED_OVERVIEW_ANIMATION_SETTINGS_H_

6 #define ASH_COMMON_WM_OVERVIEW_SCOPED_OVERVIEW_ANIMATION_SETTINGS_H_	6 #define ASH_COMMON_WM_OVERVIEW_SCOPED_OVERVIEW_ANIMATION_SETTINGS_H_

7	7

	8 namespace ui {

	9 class ImplicitAnimationObserver;

	10 } // namespace ui

	11

8 namespace ash {	12 namespace ash {

9	13

10 // ScopedOverviewAnimationSettings correctly configures the animation	14 // ScopedOverviewAnimationSettings correctly configures the animation

11 // settings for a WmWindow given an OverviewAnimationType.	15 // settings for a WmWindow given an OverviewAnimationType.

12 class ScopedOverviewAnimationSettings {	16 class ScopedOverviewAnimationSettings {

13 public:	17 public:

14 virtual ~ScopedOverviewAnimationSettings() {}	18 virtual ~ScopedOverviewAnimationSettings() {}

	19 virtual void AddObserver(ui::ImplicitAnimationObserver* observer) = 0;
	sky 2016/09/08 18:30:16 Don't you need a remove? Don't you need a remove? varkha 2016/09/09 02:25:25 This gets a bit tricky. The short answer is, I don Show quoted text On 2016/09/08 18:30:16, sky wrote: > Don't you need a remove? This gets a bit tricky. The short answer is, I don't think so - it gets removed here [1]. This observer is added here [2] and NOT removed when ScopedOverviewAnimationSettings goes out of scope because we do not remove observers from the already running sequences - see [3]. So the observer stays observing the scheduled animations and then gets removed before OnImplicitAnimationsCompleted() is called which would do "delete this" on the observer disposing of the owned widget_. [1] - https://cs.chromium.org/chromium/src/ui/compositor/layer_animation_observer.c... [2] https://codereview.chromium.org/2239233002/diff/300001/ash/common/wm/overview... line 831. [3] See how we call animator_->observers_.RemoveObserver() (and not animator_->RemoveObserver() which would have removed the observer from the running sequences) here - https://cs.chromium.org/chromium/src/ui/compositor/scoped_layer_animation_set...
15 };	20 };

16	21

17 } // namespace ash	22 } // namespace ash

18	23

19 #endif // ASH_COMMON_WM_OVERVIEW_SCOPED_OVERVIEW_ANIMATION_SETTINGS_H_	24 #endif // ASH_COMMON_WM_OVERVIEW_SCOPED_OVERVIEW_ANIMATION_SETTINGS_H_

OLD	NEW