Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2239213002: DevTools: WI.NavigatorView._removeUISourceCode should not remove frame nodes (Closed)

Created:
4 years, 4 months ago by lushnikov
Modified:
4 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: WI.NavigatorView._removeUISourceCode should not remove frame nodes Frame node removal is handled in FrameDetached event separately; otherwise, frames are considered to be attached. BUG=600517 R=pfeldman Committed: https://crrev.com/690e72757d0dde68d46ade4fd7747e082e4790c1 Cr-Commit-Position: refs/heads/master@{#411704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
lushnikov
please, take a look!
4 years, 4 months ago (2016-08-12 04:14:44 UTC) #1
pfeldman
lgtm
4 years, 4 months ago (2016-08-12 18:10:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239213002/1
4 years, 4 months ago (2016-08-12 18:14:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 18:24:56 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 18:26:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/690e72757d0dde68d46ade4fd7747e082e4790c1
Cr-Commit-Position: refs/heads/master@{#411704}

Powered by Google App Engine
This is Rietveld 408576698