Add "repaint" option to PaintSingleFrame

Add "repaint" option to PaintSingleFrame

The VideoFrameCompositor currently ignores calls to PaintSingleFrame()
if the passed frame is the same as the last frame.

StreamTextureWrapper's (STW) GetCurrentFrame() always returns the same
frame, whilst the underlying texture information has been updated. This
means that it is impossible to use STW's frame with the
PaintSingleFrame() method.

This change adds a "repaint_duplicate_frame" boolean to the
PaintSingleFrame() method, allowing the MediaPlayerRendererClient to
pass the STW's frame directly.

Instead of using the VideoRendererSink interface:
It would have been possible to have STW implement the
VideoFrameProvider interface. This meant that WMPI would have had to
own a STW and create a different VideoLayer, which would have been
more complex to understand, and likely harder to maintain.

Instead of using the PaintSingleFrame method:
It would have also been possible to have STW implement the
RenderCallback interface. However, this would lead to issues due the
different rate at which Render() is called, versus the rate at which
MediaPlayer actuall outputs frames (and would probably degrade
performance).

BUG=636002
Committed: https://crrev.com/3a03dae98226541c80bceff2ee8fd97e2cde8fcc
Cr-Commit-Position: refs/heads/master@{#411773}

[tguilbert, 2016-08-12 00:23:04]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[tguilbert, 2016-08-12 00:23:33]

tguilbert@chromium.org changed reviewers:
+ dalecurtis@google.com, watk@chromium.org

[tguilbert, 2016-08-12 00:23:33]

PTAL!

Thanks!
Thomas

[commit-bot: I haz the power, 2016-08-12 00:24:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 01:57:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 01:57:58]

Dry run: This issue passed the CQ dry run.

[watk, 2016-08-12 20:59:40]

lgtm

[tguilbert, 2016-08-12 21:12:55]

The CQ bit was checked by tguilbert@chromium.org

[commit-bot: I haz the power, 2016-08-12 21:13:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 21:18:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 21:24:07]

Description was changed from

==========
Add "repaint" option to PaintSingleFrame

The VideoFrameCompositor currently ignores calls to PaintSingleFrame()
if the passed frame is the same as the last frame.

StreamTextureWrapper's (STW) GetCurrentFrame() always returns the same
frame, whilst the underlying texture information has been updated. This
means that it is impossible to use STW's frame with the
PaintSingleFrame() method.

This change adds a "repaint_duplicate_frame" boolean to the
PaintSingleFrame() method, allowing the MediaPlayerRendererClient to
pass the STW's frame directly.


Instead of using the VideoRendererSink interface:
It would have been possible to have STW implement the
VideoFrameProvider interface. This meant that WMPI would have had to
own a STW and create a different VideoLayer, which would have been
more complex to understand, and likely harder to maintain.

Instead of using the PaintSingleFrame method:
It would have also been possible to have STW implement the
RenderCallback interface. However, this would lead to issues due the
different rate at which Render() is called, versus the rate at which
MediaPlayer actuall outputs frames (and would probably degrade
performance).

BUG=636002
==========

to

==========
Add "repaint" option to PaintSingleFrame

The VideoFrameCompositor currently ignores calls to PaintSingleFrame()
if the passed frame is the same as the last frame.

StreamTextureWrapper's (STW) GetCurrentFrame() always returns the same
frame, whilst the underlying texture information has been updated. This
means that it is impossible to use STW's frame with the
PaintSingleFrame() method.

This change adds a "repaint_duplicate_frame" boolean to the
PaintSingleFrame() method, allowing the MediaPlayerRendererClient to
pass the STW's frame directly.

Instead of using the VideoRendererSink interface:
It would have been possible to have STW implement the
VideoFrameProvider interface. This meant that WMPI would have had to
own a STW and create a different VideoLayer, which would have been
more complex to understand, and likely harder to maintain.

Instead of using the PaintSingleFrame method:
It would have also been possible to have STW implement the
RenderCallback interface. However, this would lead to issues due the
different rate at which Render() is called, versus the rate at which
MediaPlayer actuall outputs frames (and would probably degrade
performance).

BUG=636002

Committed: https://crrev.com/3a03dae98226541c80bceff2ee8fd97e2cde8fcc
Cr-Commit-Position: refs/heads/master@{#411773}
==========

[commit-bot: I haz the power, 2016-08-12 21:24:08]

Patchset 1 (id:??) landed as
https://crrev.com/3a03dae98226541c80bceff2ee8fd97e2cde8fcc
Cr-Commit-Position: refs/heads/master@{#411773}