chrome/chrome_browser.gypi - Issue 2239133002: [Offline pages] Downloads UI: Adding bridge for issuing notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 2239133002: [Offline pages] Downloads UI: Adding bridge for issuing notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@download-notifications

Patch Set: Addressing CR feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.cc ('k') | components/offline_pages.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 67210665f90b1620cd31198921e763af3719234b..d3c9483967a2ae95ac754f933e7620d514d2717f 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1654,6 +1654,8 @@

'browser/android/offline_pages/request_coordinator_factory.h',

'browser/android/offline_pages/downloads/offline_page_download_bridge.cc',

'browser/android/offline_pages/downloads/offline_page_download_bridge.h',

+ 'browser/android/offline_pages/downloads/offline_page_notification_bridge.cc',

+ 'browser/android/offline_pages/downloads/offline_page_notification_bridge.h',

'chrome_browser_browser_process_sources': [

'browser/browser_process.cc',

@@ -2070,6 +2072,7 @@

'android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java',

'android/java/src/org/chromium/chrome/browser/offlinepages/SavePageRequest.java',

'android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java',

+ 'android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java',

'android/java/src/org/chromium/chrome/browser/omnibox/AnswersImage.java',

'android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java',

'android/java/src/org/chromium/chrome/browser/omnibox/OmniboxPrerender.java',