Chromium Code Reviews| Index: dbus/object_manager.h |
| diff --git a/dbus/object_manager.h b/dbus/object_manager.h |
| index 266b53eb9a0ac3d140d468114701af3ecad17ba9..1da300a1ae760224111e6ccfdbaef1c7b8d85f26 100644 |
| --- a/dbus/object_manager.h |
| +++ b/dbus/object_manager.h |
| @@ -71,8 +71,9 @@ |
| // object_manager_->UnregisterInterface(kInterface); |
| // } |
| // |
| -// The D-Bus thread manager takes care of issuing the necessary call to |
| -// GetManagedObjects() after the implementation classes have been set up. |
| +// This class calls GetManagedObjects() asynchronously after the remote service |
| +// becomes available and additionally refreshes managed objects after the |
| +// service stops or restarts. |
| // |
| // The object manager interface class has one abstract method that must be |
| // implemented by the class to create Properties structures on demand. As well |
| @@ -238,19 +239,21 @@ public: |
| private: |
| friend class base::RefCountedThreadSafe<ObjectManager>; |
| - // Connects the InterfacesAdded and InterfacesRemoved signals and calls |
| - // GetManagedObjects. Called from OnSetupMatchRuleAndFilterComplete. |
| - void InitializeObjects(); |
|
Daniel Erat
2016/09/01 17:06:25
i moved this into OnSetupMatchRuleAndFilterComplet
|
| - |
| // Called from the constructor to add a match rule for PropertiesChanged |
| // signals on the DBus thread and set up a corresponding filter function. |
| bool SetupMatchRuleAndFilter(); |
| // Called on the origin thread once the match rule and filter have been set |
| - // up. |success| is false, if an error occurred during set up; it's true |
| - // otherwise. |
| + // up. Connects the InterfacesAdded and InterfacesRemoved signals and calls |
| + // ObjectProxy::WaitForServiceToBeAvailable to initially refresh objects. |
| + // |success| is false if an error occurred during setup and true otherwise. |
| void OnSetupMatchRuleAndFilterComplete(bool success); |
| + // Callback for ObjectProxy::WaitForServiceToBeAvailable that refreshes |
| + // objects when the service becomes initially available. Scheduled by |
| + // OnSetupMatchRuleAndFilterComplete. |
| + void OnServiceInitiallyAvailable(bool service_is_available); |
| + |
| // Called by dbus:: when a message is received. This is used to filter |
| // PropertiesChanged signals from the correct sender and relay the event to |
| // the correct PropertySet. |