dbus/bus.cc - Issue 2239123002: dbus: Make Bus::GetManagedObjects skip unavailable services.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dbus/bus.cc

Issue 2239123002: dbus: Make Bus::GetManagedObjects skip unavailable services. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove Bus::GetManagedObjects and BluezDBusManager's call to it Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dbus/bus.cc

diff --git a/dbus/bus.cc b/dbus/bus.cc

index d6e2c5b6401459e6322d1a3d9e593d03ee9ae55e..186c9380d0f2b955707e8b8f7219177620a37182 100644

--- a/dbus/bus.cc

+++ b/dbus/bus.cc

@@ -400,13 +400,6 @@ void Bus::RemoveObjectManagerInternalHelper(

callback.Run();

}

-void Bus::GetManagedObjects() {

- for (ObjectManagerTable::iterator iter = object_manager_table_.begin();

- iter != object_manager_table_.end(); ++iter) {

- iter->second->GetManagedObjects();

- }

bool Bus::Connect() {

// dbus_bus_get_private() and dbus_bus_get() are blocking calls.

AssertOnDBusThread();

« no previous file with comments | « dbus/bus.h ('k') | dbus/mock_object_manager.h » ('j') | dbus/object_manager.cc » ('J')