Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2602)

Unified Diff: dbus/bus.cc

Issue 2239123002: dbus: Make Bus::GetManagedObjects skip unavailable services. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dbus/object_manager.h » ('j') | dbus/object_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/bus.cc
diff --git a/dbus/bus.cc b/dbus/bus.cc
index d6e2c5b6401459e6322d1a3d9e593d03ee9ae55e..4b853e0b2cdbf9ce70216fbd7f8bed9eb832fce0 100644
--- a/dbus/bus.cc
+++ b/dbus/bus.cc
@@ -403,7 +403,9 @@ void Bus::RemoveObjectManagerInternalHelper(
void Bus::GetManagedObjects() {
for (ObjectManagerTable::iterator iter = object_manager_table_.begin();
iter != object_manager_table_.end(); ++iter) {
- iter->second->GetManagedObjects();
+ // Don't spam the logs with D-Bus errors if the service is unavailable.
+ if (iter->second->ServiceIsAvailable())
+ iter->second->GetManagedObjects();
}
}
« no previous file with comments | « no previous file | dbus/object_manager.h » ('j') | dbus/object_proxy.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698