Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2239103002:
Add histograms to record QUIC Min and Smoothed RTT. (Closed)
|
Created:
4 years, 4 months ago by Ryan Hamilton Modified:
4 years, 4 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd histograms to record QUIC Min and Smoothed RTT.
BUG=637314
Committed: https://crrev.com/dfbd0976c29da9edc48671ba785861abd007742e
Cr-Commit-Position: refs/heads/master@{#411918}
Patch Set 1 #
Total comments: 4
Patch Set 2 : units #
Messages
Total messages: 21 (9 generated)
rch@chromium.org changed reviewers: + cbentzel@chromium.org, rkaplow@chromium.org
rkaplow@chromium.org changed reviewers: + gayane@chromium.org
Can you create a bug for this and associate it with this? Otherwise this looks fine with potential exception for issue below. https://codereview.chromium.org/2239103002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2239103002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:30416: +<histogram name="Net.QuicSession.MinRTT"> Does this need units=ms specified?
LGTM https://codereview.chromium.org/2239103002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2239103002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:30621: +<histogram name="Net.QuicSession.SmoothedRTT"> units here as well
lgtm lg when units are added as comments request
Description was changed from ========== Add histograms to record QUIC Min and Smoothed RTT. ========== to ========== Add histograms to record QUIC Min and Smoothed RTT. BUG=637314 ==========
https://codereview.chromium.org/2239103002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2239103002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:30416: +<histogram name="Net.QuicSession.MinRTT"> On 2016/08/12 14:16:37, cbentzel wrote: > Does this need units=ms specified? Done. https://codereview.chromium.org/2239103002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:30621: +<histogram name="Net.QuicSession.SmoothedRTT"> On 2016/08/12 15:11:47, gayane wrote: > units here as well Done.
On 2016/08/12 14:16:37, cbentzel wrote: > Can you create a bug for this and associate it with this? Done.
The CQ bit was checked by rch@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org, gayane@chromium.org Link to the patchset: https://codereview.chromium.org/2239103002/#ps20001 (title: "units")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/12 16:32:04, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by cbentzel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add histograms to record QUIC Min and Smoothed RTT. BUG=637314 ========== to ========== Add histograms to record QUIC Min and Smoothed RTT. BUG=637314 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add histograms to record QUIC Min and Smoothed RTT. BUG=637314 ========== to ========== Add histograms to record QUIC Min and Smoothed RTT. BUG=637314 Committed: https://crrev.com/dfbd0976c29da9edc48671ba785861abd007742e Cr-Commit-Position: refs/heads/master@{#411918} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/dfbd0976c29da9edc48671ba785861abd007742e Cr-Commit-Position: refs/heads/master@{#411918} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
