Issue 22391008: MIPS: Optimize DoCheckMaps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22391008: MIPS: Optimize DoCheckMaps. (Closed)

Created:
7 years, 4 months ago by Paul Lind

Modified:
7 years, 4 months ago

Reviewers:
kisg, palfia, kilvadyb, danno, dusmil

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Optimize DoCheckMaps. This simple change moves the Deoptimize call into the Deopt table where it belongs, and shortens the inline map-check. Gives a surprisingly large performance gain, around 4% on Octane. BUG= R=gergely@homejinni.com Committed: https://code.google.com/p/v8/source/detail?r=16115

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

7 years, 4 months ago (2013-08-08 05:04:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r16115 (presubmit successful).

Expand Messages | Collapse Messages