Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2239063004: Fix an issue that "save video" context menu appears for MSE video (Closed)

Created:
4 years, 4 months ago by qinmin
Modified:
4 years, 4 months ago
Reviewers:
Yaron, DaleCurtis
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that "save video" context menu appears for MSE video We should use media_flags to determine if a video can be saved. BUG=637010 Committed: https://crrev.com/16006f8e310a6b0da0988b558f661003a8bd262e Committed: https://crrev.com/de0ea7338899803310109c27050fbbfef958f3f6 Cr-Original-Commit-Position: refs/heads/master@{#411807} Cr-Commit-Position: refs/heads/master@{#412027}

Patch Set 1 #

Patch Set 2 : fix java test on marshellow tablet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java View 3 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/context_menu_helper.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
qinmin
PTAL
4 years, 4 months ago (2016-08-12 18:32:51 UTC) #2
Yaron
lgtm
4 years, 4 months ago (2016-08-12 20:29:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239063004/1
4 years, 4 months ago (2016-08-12 20:47:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 22:50:51 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/16006f8e310a6b0da0988b558f661003a8bd262e Cr-Commit-Position: refs/heads/master@{#411807}
4 years, 4 months ago (2016-08-12 22:55:42 UTC) #8
nyquist
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2244343002/ by nyquist@chromium.org. ...
4 years, 4 months ago (2016-08-15 17:45:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239063004/20001
4 years, 4 months ago (2016-08-15 19:27:12 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-15 20:10:20 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 20:18:31 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de0ea7338899803310109c27050fbbfef958f3f6
Cr-Commit-Position: refs/heads/master@{#412027}

Powered by Google App Engine
This is Rietveld 408576698