[system health] Add power system health benchmarks

tools/perf/benchmarks/system_health.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from core import perf_benchmark
 from telemetry import benchmark
 from telemetry.timeline import chrome_trace_category_filter
 from telemetry.web_perf import timeline_based_measurement
@@ skipping 38 matching lines @@
   def Name(cls):
     return 'system_health.memory_%s' % cls.PLATFORM
 
   @classmethod
   def ValueCanBeAddedPredicate(cls, value, is_first_result):
     # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
     # is able to cope with the data load generated by TBMv2 metrics.
     return not _IGNORED_STATS_RE.search(value.name)
 
 
+class _PowerSystemHealthBenchmark(perf_benchmark.PerfBenchmark):

[petrcermak, 2016/08/12 09:03:00]

Instead of interleaving the classes:

_MemorySystemHealthBenchmark
_PowerSystemHealthBenchmark
DesktopMemorySystemHealthBenchmark
...
DesktopPowerSystemHealthBenchmark
...

Please keep each group together:

_MemorySystemHealthBenchmark
DesktopMemorySystemHealthBenchmark
...
_PowerSystemHealthBenchmark
DesktopPowerSystemHealthBenchmark
...

[charliea (OOO until 10-5), 2016/08/12 14:18:43]

Done.

+  """Chrome Power System Health Benchmark.
+
+  https://goo.gl/Jek2NL.
+  """
+
+  def CreateTimelineBasedMeasurementOptions(self):
+    options = timeline_based_measurement.Options()
+    options.config.enable_battor_trace = True
+    options.config.enable_chrome_trace = True
+    options.config.chrome_trace_config.SetDefaultOverheadFilter()
+    options.SetTimelineBasedMetrics(['powerMetric', 'clockSyncLatencyMetric'])
+    return options
+
+  def CreateStorySet(self, options):
+    return page_sets.SystemHealthStorySet(platform=self.PLATFORM)
+
+  @classmethod
+  def ShouldTearDownStateAfterEachStoryRun(cls):
+    return True
+
+  @classmethod
+  def Name(cls):
+    return 'system_health.power_%s' % cls.PLATFORM
+
+  @classmethod
+  def ValueCanBeAddedPredicate(cls, value, is_first_result):
+    # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
+    # is able to cope with the data load generated by TBMv2 metrics.
+    return not _IGNORED_STATS_RE.search(value.name)

[petrcermak, 2016/08/12 09:03:00]

How many values does your metric generate? If it's only a couple, then you don't
need this (we need it in memory because we are producing hundreds of values).

[charliea (OOO until 10-5), 2016/08/12 14:18:43]

Done.

+
+
 class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark):
   """Desktop Chrome Memory System Health Benchmark."""
   PLATFORM = 'desktop'
 
   @classmethod
   def ShouldDisable(cls, possible_browser):
     # http://crbug.com/624355 (reference builds).
     return (possible_browser.platform.GetDeviceTypeName() != 'Desktop' or
             possible_browser.browser_type == 'reference')
 
 
 class MobileMemorySystemHealth(_MemorySystemHealthBenchmark):
   """Mobile Chrome Memory System Health Benchmark."""
   PLATFORM = 'mobile'
 
   @classmethod
   def ShouldDisable(cls, possible_browser):
     # http://crbug.com/612144
     if (possible_browser.browser_type == 'reference' and
         possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
       return True
 
     return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
 
 
+class DesktopPowerSystemHealth(_PowerSystemHealthBenchmark):
+  """Desktop Chrome Energy System Health Benchmark."""
+  PLATFORM = 'desktop'
+
+  @classmethod
+  def ShouldDisable(cls, possible_browser):
+    # http://crbug.com/624355 (reference builds).
+    return (possible_browser.platform.GetDeviceTypeName() != 'Desktop' or
+            possible_browser.browser_type == 'reference' or
+            not possible_browser.platform.HasBattOrConnected())
+
+
+class MobilePowerSystemHealth(_PowerSystemHealthBenchmark):
+  """Mobile Chrome Energy System Health Benchmark."""
+  PLATFORM = 'mobile'
+
+  @classmethod
+  def ShouldDisable(cls, possible_browser):
+    # http://crbug.com/612144
+    if (possible_browser.browser_type == 'reference' and
+        possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
+      return True
+
+    return (possible_browser.platform.GetDeviceTypeName() == 'Desktop' or
+            not possible_browser.platform.HasBattOrConnected())
+
+
 @benchmark.Enabled('android-webview')
 class WebviewStartupSystemHealthBenchmark(perf_benchmark.PerfBenchmark):
   """Webview startup time benchmark
 
   Benchmark that measures how long WebView takes to start up
   and load a blank page. Since thie metric only requires the trace
   markers recorded in atrace, Chrome tracing is not enabled for this
   benchmark.
   """
   page_set = page_sets.BlankPageSet
 
   def CreateTimelineBasedMeasurementOptions(self):
     options = timeline_based_measurement.Options()
     options.SetTimelineBasedMetrics(['webviewStartupMetric'])
     options.config.enable_atrace_trace = True
     options.config.enable_chrome_trace = False
     options.config.atrace_config.app_name = 'org.chromium.webview_shell'
     return options
 
   @classmethod
   def ShouldTearDownStateAfterEachStoryRun(cls):
     return True
 
   @classmethod
   def Name(cls):
     return 'system_health.webview_startup'