Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2239043002: Rebaseline some opacity tests because they are only off-by-one color (Closed)

Created:
4 years, 4 months ago by Stephen Chennney
Modified:
4 years, 4 months ago
Reviewers:
danakj, chrishtr
CC:
chrishtr, blink-reviews, chromium-reviews, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline some opacity tests because they are only off-by-one color These were ref-tests, so deleting them, and marking for rebaseline to get new results. The results look like the references but they are off by one in the actual pixel values. Efforts to change the reference failed because the opacity blending cannot be replaced because it affects the text color and aliasing, yet we can't choose other colors to get the right blended result. R=danajk@chromium.org BUG=240374, 636475 Committed: https://crrev.com/b90be20b69c308a9204656194dc31670fe2b80e7 Cr-Commit-Position: refs/heads/master@{#411416}

Patch Set 1 #

Messages

Total messages: 17 (12 generated)
Stephen Chennney
I tried to modify the reference results but no luck due to the complications of ...
4 years, 4 months ago (2016-08-11 19:09:36 UTC) #5
chrishtr
lgtm
4 years, 4 months ago (2016-08-11 20:28:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239043002/1
4 years, 4 months ago (2016-08-11 20:29:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 20:34:28 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 20:36:03 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b90be20b69c308a9204656194dc31670fe2b80e7
Cr-Commit-Position: refs/heads/master@{#411416}

Powered by Google App Engine
This is Rietveld 408576698