Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 223903008: Revert of Properly set alpha type in webp decode. (Closed)

Created:
6 years, 8 months ago by scroggo
Modified:
6 years, 8 months ago
Reviewers:
hal.canary
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Properly set alpha type in webp decode. (https://codereview.chromium.org/223893002/) Reason for revert: Breaks ImageDecoding tests on several platforms. Original issue's description: > Properly set alpha type in webp decode. > > Also use the newer setConfig function. > > Add a test to confirm that we set the alpha type properly. > > Add some images with alpha for testing. (These images are also beneficial for the compare_unpremul test, which was previously not meaningful on 100% opaque images.) > > All of the added images are in the public domain. They were taken from https://developers.google.com/speed/webp/gallery2: > > yellow_rose: > "Free Stock Photo in High Resolution - Yellow Rose 3 - Flowers" > Image Author: Jon Sullivan > This file is in the public domain. > http://www.public-domain-photos.com/free-stock-photos-4/flowers/yellow-rose-3.jpg > > baby_tux: > "baby tux for my user page" > Image Author: Fizyplankton > This file is in the public domain. > http://www.minecraftwiki.net/images/8/85/Fizyplankton.png > > NOTRY=true > > Committed: http://code.google.com/p/skia/source/detail?r=14054 TBR=halcanary@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -168 lines) Patch
D resources/baby_tux.png View Binary file 0 comments Download
D resources/baby_tux.webp View Binary file 0 comments Download
D resources/half-transparent-white-pixel.png View Binary file 0 comments Download
D resources/half-transparent-white-pixel.webp View Binary file 0 comments Download
D resources/yellow_rose.png View Binary file 0 comments Download
D resources/yellow_rose.webp View Binary file 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 1 chunk +2 lines, -14 lines 0 comments Download
M tests/ImageDecodingTest.cpp View 1 chunk +0 lines, -154 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Created Revert of Properly set alpha type in webp decode.
6 years, 8 months ago (2014-04-03 21:46:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/223903008/1
6 years, 8 months ago (2014-04-03 21:47:02 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 21:47:21 UTC) #3
Message was sent while issue was closed.
Change committed as 14055

Powered by Google App Engine
This is Rietveld 408576698