Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2239023002: Removing protobuf ProGuard keep (Closed)

Created:
4 years, 4 months ago by smaier
Modified:
4 years, 4 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing protobuf ProGuard keep This removes: -class com.google.protobuf.nano.android.ParcelableExtendableMessageNano -class com.google.protobuf.nano.Extension -class com.google.protobuf.nano.android.ParcelableMessageNano -class com.google.protobuf.nano.Extension$PrimitiveExtension com.google.protobuf.nano.InternalNano - void <init>() com.google.protobuf.nano.WireFormatNano - void <init>() -class com.google.protobuf.nano.android.ParcelableMessageNanoCreator com.google.protobuf.nano.MessageNanoPrinter - void <init>() BUG=619937 Committed: https://crrev.com/6441843cbd709ba4016d1796c92e61c21bf1dcc3 Cr-Commit-Position: refs/heads/master@{#411408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/android/java/proguard.flags View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
smaier
4 years, 4 months ago (2016-08-11 18:45:29 UTC) #4
agrieve
On 2016/08/11 18:45:29, smaier wrote: lgtm
4 years, 4 months ago (2016-08-11 18:49:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239023002/1
4 years, 4 months ago (2016-08-11 19:41:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 19:47:57 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 19:50:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6441843cbd709ba4016d1796c92e61c21bf1dcc3
Cr-Commit-Position: refs/heads/master@{#411408}

Powered by Google App Engine
This is Rietveld 408576698