Assign correct track ids to buffers emitted from StreamParsers

Assign correct track ids to buffers emitted from StreamParsers

Currently only the WebM stream parser assigns correct track bytestream
ids for each emitted buffer. We need to ensure that other stream parsers
(MP4, mpeg2ts, etc) do the same.

BUG=636999
Committed: https://crrev.com/06a15b52d5f3f5cf05559afc0f03a60e4f289e21
Cr-Commit-Position: refs/heads/master@{#411498}

[servolk, 2016-08-11 17:29:05]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[servolk, 2016-08-11 17:29:34]

Description was changed from

==========
Assign correct track ids to buffers emitted from StreamParsers

Currently only the WebM stream parser assigns correct track bytestream
ids for each emitted buffer. We need to ensure that other stream parsers
(MP4, mpeg2ts, etc) do the same.

BUG=636999
==========

to

==========
Assign correct track ids to buffers emitted from StreamParsers

Currently only the WebM stream parser assigns correct track bytestream
ids for each emitted buffer. We need to ensure that other stream parsers
(MP4, mpeg2ts, etc) do the same.

BUG=636999
==========

[servolk, 2016-08-11 17:29:34]

servolk@chromium.org changed reviewers:
+ chcunningham@chromium.org, wolenetz@chromium.org

[commit-bot: I haz the power, 2016-08-11 17:29:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 19:55:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 19:55:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[wolenetz, 2016-08-11 21:48:21]

LGTM

Have you tried running the init-segment-received layout tests on a local
chromium build that includes proprietary codecs (for mp4), but has webm support
disabled in stream_parser_factory.cc? I assume that would fail before this CL
and succeed after.

[wolenetz, 2016-08-11 21:49:03]

On 2016/08/11 21:48:21, wolenetz wrote:
> LGTM
> 
> Have you tried running the init-segment-received layout tests on a local
> chromium build that includes proprietary codecs (for mp4), but has webm
support
> disabled in stream_parser_factory.cc? I assume that would fail before this CL
> and succeed after.

Also, note that chcunningham@ is OoO until Monday.

[servolk, 2016-08-11 21:55:22]

On 2016/08/11 21:48:21, wolenetz wrote:
> LGTM
> 
> Have you tried running the init-segment-received layout tests on a local
> chromium build that includes proprietary codecs (for mp4), but has webm
support
> disabled in stream_parser_factory.cc? I assume that would fail before this CL
> and succeed after.

Just tried the init-segment-received layout test with webm support disabled and
it still fails. But yes, this change brings us one step closer to fixing that.
Here is the failures that I got:

This is a testharness.js-based test.
FAIL Same init segment appended twice assert_unreached: No segment info
compatible with this MediaSource implementation. Reached unreachable code
FAIL Track defaults processing in the init segment algorithm (explicit
bytestream ids) assert_unreached: No segment info compatible with this
MediaSource implementation. Reached unreachable code
FAIL Track defaults processing in the init segment algorithm (no bytestream ids)
assert_unreached: No segment info compatible with this MediaSource
implementation. Reached unreachable code
FAIL Two source buffers with clashing bytestream track ids assert_unreached:
Invalid mimetype '' Reached unreachable code
Harness: the test ran to completion.

[servolk, 2016-08-11 21:55:28]

The CQ bit was checked by servolk@chromium.org

[commit-bot: I haz the power, 2016-08-11 21:56:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[servolk, 2016-08-11 22:38:00]

The CQ bit was unchecked by servolk@chromium.org

[servolk, 2016-08-11 22:38:12]

The CQ bit was checked by servolk@chromium.org

[commit-bot: I haz the power, 2016-08-11 22:38:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 01:03:36]

Description was changed from

==========
Assign correct track ids to buffers emitted from StreamParsers

Currently only the WebM stream parser assigns correct track bytestream
ids for each emitted buffer. We need to ensure that other stream parsers
(MP4, mpeg2ts, etc) do the same.

BUG=636999
==========

to

==========
Assign correct track ids to buffers emitted from StreamParsers

Currently only the WebM stream parser assigns correct track bytestream
ids for each emitted buffer. We need to ensure that other stream parsers
(MP4, mpeg2ts, etc) do the same.

BUG=636999
==========

[commit-bot: I haz the power, 2016-08-12 01:03:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 01:05:15]

Description was changed from

==========
Assign correct track ids to buffers emitted from StreamParsers

Currently only the WebM stream parser assigns correct track bytestream
ids for each emitted buffer. We need to ensure that other stream parsers
(MP4, mpeg2ts, etc) do the same.

BUG=636999
==========

to

==========
Assign correct track ids to buffers emitted from StreamParsers

Currently only the WebM stream parser assigns correct track bytestream
ids for each emitted buffer. We need to ensure that other stream parsers
(MP4, mpeg2ts, etc) do the same.

BUG=636999

Committed: https://crrev.com/06a15b52d5f3f5cf05559afc0f03a60e4f289e21
Cr-Commit-Position: refs/heads/master@{#411498}
==========

[commit-bot: I haz the power, 2016-08-12 01:05:16]

Patchset 1 (id:??) landed as
https://crrev.com/06a15b52d5f3f5cf05559afc0f03a60e4f289e21
Cr-Commit-Position: refs/heads/master@{#411498}