third_party/WebKit/Source/core/html/PluginDocument.cpp - Issue 2238983002: Do not try to use an HTML embed instead of a Flash one inside a PluginDocument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/PluginDocument.cpp

Issue 2238983002: Do not try to use an HTML embed instead of a Flash one inside a PluginDocument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/PluginDocument.cpp

diff --git a/third_party/WebKit/Source/core/html/PluginDocument.cpp b/third_party/WebKit/Source/core/html/PluginDocument.cpp

index 221c5a4c17499778a45fd3c877e1777c38d8a2f0..8f4f31157243e27f541b4a4fd12e3c9aea1403af 100644

--- a/third_party/WebKit/Source/core/html/PluginDocument.cpp

+++ b/third_party/WebKit/Source/core/html/PluginDocument.cpp

@@ -178,7 +178,7 @@ DocumentParser* PluginDocument::createParser()

Widget* PluginDocument::pluginWidget()

{

if (m_pluginNode && m_pluginNode->layoutObject()) {

- ASSERT(m_pluginNode->layoutObject()->isEmbeddedObject());

+ CHECK(m_pluginNode->layoutObject()->isEmbeddedObject());

return toLayoutEmbeddedObject(m_pluginNode->layoutObject())->widget();

}

return 0;

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp ('k') | no next file » | no next file with comments »