Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2238973002: bluetooth: Add missing return when bluetooth not supported. (Closed)

Created:
4 years, 4 months ago by ortuno
Modified:
4 years, 4 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, darin-cc_chromium.org, jam, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Add missing return when bluetooth not supported. This was causing a null pointer derefence in line 317. BUG=636976 Committed: https://crrev.com/b38275d302118a3c5d8437314e08481c8a167d32 Cr-Commit-Position: refs/heads/master@{#411663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
ortuno
jyasskin: PTAL
4 years, 4 months ago (2016-08-11 15:53:15 UTC) #2
Jeffrey Yasskin
Argh. LGTM
4 years, 4 months ago (2016-08-11 16:13:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238973002/1
4 years, 4 months ago (2016-08-11 16:17:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/271941)
4 years, 4 months ago (2016-08-11 18:03:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238973002/1
4 years, 4 months ago (2016-08-12 14:28:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 15:56:12 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 15:58:16 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b38275d302118a3c5d8437314e08481c8a167d32
Cr-Commit-Position: refs/heads/master@{#411663}

Powered by Google App Engine
This is Rietveld 408576698