Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2238953002: Moving flags out of base_proguard_config make it usable by other .apks (Closed)

Created:
4 years, 4 months ago by smaier
Modified:
4 years, 4 months ago
Reviewers:
agrieve, Torne, xunjieli
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving flags out of base_proguard_config make it usable by other .apks Cronet wants to use base_proguad_config, and these flags don't make sense for them. Moving these flags back to individual flags files. BUG=619937 Committed: https://crrev.com/9f76569fe690db5de5395cc9a62313a1d8300c60 Cr-Commit-Position: refs/heads/master@{#412258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -21 lines) Patch
M android_webview/apk/java/proguard.flags View 1 chunk +18 lines, -0 lines 0 comments Download
M base/android/base_proguard_config.flags View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/android/java/proguard.flags View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
smaier
agrieve@chromium.org: Please review changes in base + chrome proguard configs torne@chromium.org: Please review changes in ...
4 years, 4 months ago (2016-08-11 15:28:42 UTC) #2
xunjieli
Thanks a lot!
4 years, 4 months ago (2016-08-11 15:45:49 UTC) #6
agrieve
On 2016/08/11 15:45:49, xunjieli wrote: > Thanks a lot! lgtm
4 years, 4 months ago (2016-08-11 17:18:40 UTC) #7
Torne
LGTM, sorry, missed this one :)
4 years, 4 months ago (2016-08-16 14:50:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238953002/1
4 years, 4 months ago (2016-08-16 15:26:24 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 16:06:50 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 16:08:47 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f76569fe690db5de5395cc9a62313a1d8300c60
Cr-Commit-Position: refs/heads/master@{#412258}

Powered by Google App Engine
This is Rietveld 408576698