Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 223893002: Properly set alpha type in webp decode. (Closed)

Created:
6 years, 8 months ago by scroggo
Modified:
6 years, 8 months ago
Reviewers:
hal.canary
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Properly set alpha type in webp decode. Also use the newer setConfig function. Add a test to confirm that we set the alpha type properly. Add some images with alpha for testing. (These images are also beneficial for the compare_unpremul test, which was previously not meaningful on 100% opaque images.) All of the added images are in the public domain. They were taken from https://developers.google.com/speed/webp/gallery2: yellow_rose: "Free Stock Photo in High Resolution - Yellow Rose 3 - Flowers" Image Author: Jon Sullivan This file is in the public domain. http://www.public-domain-photos.com/free-stock-photos-4/flowers/yellow-rose-3.jpg baby_tux: "baby tux for my user page" Image Author: Fizyplankton This file is in the public domain. http://www.minecraftwiki.net/images/8/85/Fizyplankton.png NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14054

Patch Set 1 #

Patch Set 2 : Add a test and test images. #

Patch Set 3 : Fix comment and remove printf. #

Patch Set 4 : Remove gregor_mendel, which may not be public domain. #

Patch Set 5 : Another test. #

Total comments: 2

Patch Set 6 : Add valid check. break -> continue. #

Patch Set 7 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -2 lines) Patch
A resources/baby_tux.png View 1 Binary file 0 comments Download
A resources/baby_tux.webp View 1 Binary file 0 comments Download
A resources/half-transparent-white-pixel.png View 1 2 3 4 Binary file 0 comments Download
A resources/half-transparent-white-pixel.webp View 1 2 3 4 Binary file 0 comments Download
A resources/yellow_rose.png View 1 Binary file 0 comments Download
A resources/yellow_rose.webp View 1 Binary file 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 1 chunk +14 lines, -2 lines 0 comments Download
M tests/ImageDecodingTest.cpp View 1 2 3 4 5 1 chunk +154 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
scroggo
6 years, 8 months ago (2014-04-03 17:59:08 UTC) #1
hal.canary
On 2014/04/03 17:59:08, scroggo wrote: As I said in person, it looks good, but let's ...
6 years, 8 months ago (2014-04-03 19:28:18 UTC) #2
scroggo
On 2014/04/03 19:28:18, Hal Canary wrote: > On 2014/04/03 17:59:08, scroggo wrote: > > As ...
6 years, 8 months ago (2014-04-03 20:22:09 UTC) #3
hal.canary
https://codereview.chromium.org/223893002/diff/80001/tests/ImageDecodingTest.cpp File tests/ImageDecodingTest.cpp (right): https://codereview.chromium.org/223893002/diff/80001/tests/ImageDecodingTest.cpp#newcode266 tests/ImageDecodingTest.cpp:266: SkFILEStream stream(fullName.c_str()); skiatest::Test::GetResourcePath() could return a path that isn't ...
6 years, 8 months ago (2014-04-03 20:29:53 UTC) #4
hal.canary
On 2014/04/03 20:29:53, Hal Canary wrote: > skiatest::Test::GetResourcePath() could return a path that isn't the ...
6 years, 8 months ago (2014-04-03 20:32:09 UTC) #5
scroggo
https://codereview.chromium.org/223893002/diff/80001/tests/ImageDecodingTest.cpp File tests/ImageDecodingTest.cpp (right): https://codereview.chromium.org/223893002/diff/80001/tests/ImageDecodingTest.cpp#newcode266 tests/ImageDecodingTest.cpp:266: SkFILEStream stream(fullName.c_str()); On 2014/04/03 20:29:53, Hal Canary wrote: > ...
6 years, 8 months ago (2014-04-03 20:34:56 UTC) #6
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-04-03 20:35:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/223893002/100001
6 years, 8 months ago (2014-04-03 20:35:05 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 20:40:27 UTC) #9
commit-bot: I haz the power
Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
6 years, 8 months ago (2014-04-03 20:40:27 UTC) #10
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-04-03 20:43:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/223893002/120001
6 years, 8 months ago (2014-04-03 20:44:06 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 20:49:23 UTC) #13
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
6 years, 8 months ago (2014-04-03 20:49:25 UTC) #14
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-04-03 20:55:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/223893002/120001
6 years, 8 months ago (2014-04-03 20:55:22 UTC) #16
commit-bot: I haz the power
Change committed as 14054
6 years, 8 months ago (2014-04-03 20:56:05 UTC) #17
scroggo
A revert of this CL has been created in https://codereview.chromium.org/223903008/ by scroggo@google.com. The reason for ...
6 years, 8 months ago (2014-04-03 21:46:52 UTC) #18
scroggo
6 years, 8 months ago (2014-04-24 18:48:42 UTC) #19
Message was sent while issue was closed.
On 2014/04/03 21:46:52, scroggo wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/223903008/ by mailto:scroggo@google.com.
> 
> The reason for reverting is: Breaks ImageDecoding tests on several platforms..

Relanding with https://codereview.chromium.org/252423008/

Powered by Google App Engine
This is Rietveld 408576698