Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Side by Side Diff: src/objects-inl.h

Issue 2238893002: [debugger] separate break point info from code instrumentation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-debug.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 5793 matching lines...) Expand 10 before | Expand all | Expand 10 after
5804 kOriginOptionsShift); 5804 kOriginOptionsShift);
5805 } 5805 }
5806 void Script::set_origin_options(ScriptOriginOptions origin_options) { 5806 void Script::set_origin_options(ScriptOriginOptions origin_options) {
5807 DCHECK(!(origin_options.Flags() & ~((1 << kOriginOptionsSize) - 1))); 5807 DCHECK(!(origin_options.Flags() & ~((1 << kOriginOptionsSize) - 1)));
5808 set_flags((flags() & ~kOriginOptionsMask) | 5808 set_flags((flags() & ~kOriginOptionsMask) |
5809 (origin_options.Flags() << kOriginOptionsShift)); 5809 (origin_options.Flags() << kOriginOptionsShift));
5810 } 5810 }
5811 5811
5812 5812
5813 ACCESSORS(DebugInfo, shared, SharedFunctionInfo, kSharedFunctionInfoIndex) 5813 ACCESSORS(DebugInfo, shared, SharedFunctionInfo, kSharedFunctionInfoIndex)
5814 ACCESSORS(DebugInfo, abstract_code, AbstractCode, kAbstractCodeIndex) 5814 ACCESSORS(DebugInfo, debug_bytecode_array, Object, kDebugBytecodeArrayIndex)
5815 ACCESSORS(DebugInfo, break_points, FixedArray, kBreakPointsStateIndex) 5815 ACCESSORS(DebugInfo, break_points, FixedArray, kBreakPointsStateIndex)
5816 5816
5817 BytecodeArray* DebugInfo::original_bytecode_array() { 5817 bool DebugInfo::HasDebugBytecodeArray() {
5818 return debug_bytecode_array()->IsBytecodeArray();
5819 }
5820
5821 bool DebugInfo::HasDebugCode() {
5822 Code* code = shared()->code();
5823 bool has = code->kind() == Code::FUNCTION;
5824 DCHECK(!has || code->has_debug_break_slots());
5825 return has;
5826 }
5827
5828 BytecodeArray* DebugInfo::OriginalBytecodeArray() {
5829 DCHECK(HasDebugBytecodeArray());
5818 return shared()->bytecode_array(); 5830 return shared()->bytecode_array();
5819 } 5831 }
5820 5832
5833 BytecodeArray* DebugInfo::DebugBytecodeArray() {
5834 DCHECK(HasDebugBytecodeArray());
5835 return BytecodeArray::cast(debug_bytecode_array());
5836 }
5837
5838 Code* DebugInfo::DebugCode() {
5839 DCHECK(HasDebugCode());
5840 return shared()->code();
5841 }
5842
5821 SMI_ACCESSORS(BreakPointInfo, source_position, kSourcePositionIndex) 5843 SMI_ACCESSORS(BreakPointInfo, source_position, kSourcePositionIndex)
5822 ACCESSORS(BreakPointInfo, break_point_objects, Object, kBreakPointObjectsIndex) 5844 ACCESSORS(BreakPointInfo, break_point_objects, Object, kBreakPointObjectsIndex)
5823 5845
5824 ACCESSORS(SharedFunctionInfo, name, Object, kNameOffset) 5846 ACCESSORS(SharedFunctionInfo, name, Object, kNameOffset)
5825 ACCESSORS(SharedFunctionInfo, optimized_code_map, FixedArray, 5847 ACCESSORS(SharedFunctionInfo, optimized_code_map, FixedArray,
5826 kOptimizedCodeMapOffset) 5848 kOptimizedCodeMapOffset)
5827 ACCESSORS(SharedFunctionInfo, construct_stub, Code, kConstructStubOffset) 5849 ACCESSORS(SharedFunctionInfo, construct_stub, Code, kConstructStubOffset)
5828 ACCESSORS(SharedFunctionInfo, feedback_metadata, TypeFeedbackMetadata, 5850 ACCESSORS(SharedFunctionInfo, feedback_metadata, TypeFeedbackMetadata,
5829 kFeedbackMetadataOffset) 5851 kFeedbackMetadataOffset)
5830 #if TRACE_MAPS 5852 #if TRACE_MAPS
(...skipping 2355 matching lines...) Expand 10 before | Expand all | Expand 10 after
8186 #undef WRITE_INT64_FIELD 8208 #undef WRITE_INT64_FIELD
8187 #undef READ_BYTE_FIELD 8209 #undef READ_BYTE_FIELD
8188 #undef WRITE_BYTE_FIELD 8210 #undef WRITE_BYTE_FIELD
8189 #undef NOBARRIER_READ_BYTE_FIELD 8211 #undef NOBARRIER_READ_BYTE_FIELD
8190 #undef NOBARRIER_WRITE_BYTE_FIELD 8212 #undef NOBARRIER_WRITE_BYTE_FIELD
8191 8213
8192 } // namespace internal 8214 } // namespace internal
8193 } // namespace v8 8215 } // namespace v8
8194 8216
8195 #endif // V8_OBJECTS_INL_H_ 8217 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects-debug.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698