Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/builtins/arm/builtins-arm.cc

Issue 2238893002: [debugger] separate break point info from code instrumentation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/builtins/arm64/builtins-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 1034 matching lines...) Expand 10 before | Expand all | Expand 10 after
1045 // it is present) and load it into kInterpreterBytecodeArrayRegister. 1045 // it is present) and load it into kInterpreterBytecodeArrayRegister.
1046 __ ldr(r0, FieldMemOperand(r1, JSFunction::kSharedFunctionInfoOffset)); 1046 __ ldr(r0, FieldMemOperand(r1, JSFunction::kSharedFunctionInfoOffset));
1047 Register debug_info = kInterpreterBytecodeArrayRegister; 1047 Register debug_info = kInterpreterBytecodeArrayRegister;
1048 DCHECK(!debug_info.is(r0)); 1048 DCHECK(!debug_info.is(r0));
1049 __ ldr(debug_info, FieldMemOperand(r0, SharedFunctionInfo::kDebugInfoOffset)); 1049 __ ldr(debug_info, FieldMemOperand(r0, SharedFunctionInfo::kDebugInfoOffset));
1050 __ cmp(debug_info, Operand(DebugInfo::uninitialized())); 1050 __ cmp(debug_info, Operand(DebugInfo::uninitialized()));
1051 // Load original bytecode array or the debug copy. 1051 // Load original bytecode array or the debug copy.
1052 __ ldr(kInterpreterBytecodeArrayRegister, 1052 __ ldr(kInterpreterBytecodeArrayRegister,
1053 FieldMemOperand(r0, SharedFunctionInfo::kFunctionDataOffset), eq); 1053 FieldMemOperand(r0, SharedFunctionInfo::kFunctionDataOffset), eq);
1054 __ ldr(kInterpreterBytecodeArrayRegister, 1054 __ ldr(kInterpreterBytecodeArrayRegister,
1055 FieldMemOperand(debug_info, DebugInfo::kAbstractCodeIndex), ne); 1055 FieldMemOperand(debug_info, DebugInfo::kDebugBytecodeArrayIndex), ne);
1056 1056
1057 // Check function data field is actually a BytecodeArray object. 1057 // Check function data field is actually a BytecodeArray object.
1058 Label bytecode_array_not_present; 1058 Label bytecode_array_not_present;
1059 __ CompareRoot(kInterpreterBytecodeArrayRegister, 1059 __ CompareRoot(kInterpreterBytecodeArrayRegister,
1060 Heap::kUndefinedValueRootIndex); 1060 Heap::kUndefinedValueRootIndex);
1061 __ b(eq, &bytecode_array_not_present); 1061 __ b(eq, &bytecode_array_not_present);
1062 if (FLAG_debug_code) { 1062 if (FLAG_debug_code) {
1063 __ SmiTst(kInterpreterBytecodeArrayRegister); 1063 __ SmiTst(kInterpreterBytecodeArrayRegister);
1064 __ Assert(ne, kFunctionDataShouldBeBytecodeArrayOnInterpreterEntry); 1064 __ Assert(ne, kFunctionDataShouldBeBytecodeArrayOnInterpreterEntry);
1065 __ CompareObjectType(kInterpreterBytecodeArrayRegister, r0, no_reg, 1065 __ CompareObjectType(kInterpreterBytecodeArrayRegister, r0, no_reg,
(...skipping 1830 matching lines...) Expand 10 before | Expand all | Expand 10 after
2896 __ bkpt(0); 2896 __ bkpt(0);
2897 } 2897 }
2898 } 2898 }
2899 2899
2900 #undef __ 2900 #undef __
2901 2901
2902 } // namespace internal 2902 } // namespace internal
2903 } // namespace v8 2903 } // namespace v8
2904 2904
2905 #endif // V8_TARGET_ARCH_ARM 2905 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/builtins/arm64/builtins-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698