SPv2: Use GeometryMapper to implement PaintLayerClipper.

Use GeometryMapper to implement PaintLayerClipper.

BUG=593596
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c
Cr-Commit-Position: refs/heads/master@{#423731}

[chrishtr, 2016-08-12 22:18:39]

Description was changed from

==========
none


none


none


none


none

BUG=
==========

to

==========
none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-08-12 22:20:36]

Description was changed from

==========
none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use GeometryMapper to implement PaintLayerClipper.

BUG=593596

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-08-12 23:05:48]

chrishtr@chromium.org changed reviewers:
+ trchen@chromium.org, wangxianzhu@chromium.org

[chrishtr, 2016-08-12 23:05:54]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 23:06:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 00:35:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 00:35:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-08-15 17:09:04]

https://codereview.chromium.org/2238883006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right):

https://codereview.chromium.org/2238883006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:161:
m_geometryMapper.reset(new GeometryMapper);
Can you give some performance analysis? Can we share GeometryMapper among
PaintLayers?

https://codereview.chromium.org/2238883006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.h (right):

https://codereview.chromium.org/2238883006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayerClipper.h:52: #include
"platform/graphics/paint/ClipPaintPropertyNode.h"
Nit: The XXXPaintPropertyNode.h headers are actually required by
PropertyTreeState.h so they should be included in that file.
https://codereview.chromium.org/2238853005/ does that.

[chrishtr, 2016-09-09 22:54:47]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 22:55:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 23:10:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 23:10:35]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-09-21 00:15:10]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 00:15:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 01:28:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 01:28:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2016-09-23 02:35:15]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 02:35:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 03:33:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 03:33:53]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-09-26 23:23:10]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 23:23:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 00:09:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 00:09:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2016-09-27 23:50:09]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 23:50:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 01:17:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 01:18:00]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-09-30 18:52:59]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 18:53:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 19:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 19:52:53]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-10-03 22:53:02]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 22:53:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 00:51:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 00:51:57]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-10-04 22:08:19]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 22:09:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 22:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 22:13:01]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2016-10-04 22:19:57]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 22:20:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 22:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 22:32:54]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[chrishtr, 2016-10-04 22:40:34]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 22:41:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 23:39:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 23:39:46]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-10-05 23:03:10]

Description was changed from

==========
Use GeometryMapper to implement PaintLayerClipper.

BUG=593596

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use GeometryMapper to implement PaintLayerClipper.

Turn it on in slimmingPaintInvalidation and SPv2 modes.

BUG=593596

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-10-05 23:13:58]

Description was changed from

==========
Use GeometryMapper to implement PaintLayerClipper.

Turn it on in slimmingPaintInvalidation and SPv2 modes.

BUG=593596

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use GeometryMapper to implement PaintLayerClipper.

BUG=593596

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-10-05 23:28:32]

https://codereview.chromium.org/2238883006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right):

https://codereview.chromium.org/2238883006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:161:
m_geometryMapper.reset(new GeometryMapper);
On 2016/08/15 at 17:09:04, Xianzhu wrote:
> Can you give some performance analysis?

Don't have any yet. I'd prefer to commit this first and then do a comparison
when the code is stable and known to be correct,
via the rasterize-and-record invalidation benchmark that Walter just added. What
do you think?

> Can we share GeometryMapper among PaintLayers?

Yes it can be shared, good idea. Note however that the old system couldn't do
that. I've put a TODO. Resolving that TODO is related to the above request to do
performance testing later..

https://codereview.chromium.org/2238883006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.h (right):

https://codereview.chromium.org/2238883006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayerClipper.h:52: #include
"platform/graphics/paint/ClipPaintPropertyNode.h"
On 2016/08/15 at 17:09:04, Xianzhu wrote:
> Nit: The XXXPaintPropertyNode.h headers are actually required by
PropertyTreeState.h so they should be included in that file.
https://codereview.chromium.org/2238853005/ does that.

Done.

https://codereview.chromium.org/2238883006/diff/320001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right):

https://codereview.chromium.org/2238883006/diff/320001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:106: if
(m_paintLayer.paintsWithTransform(paintingInfo.getGlobalPaintFlags()) &&
Need to call paintLayerWithTransform even for SPv2, in order to map the cull
rect to the new space.

[chrishtr, 2016-10-05 23:28:38]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 23:29:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-10-06 00:13:32]

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
(right):

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:2162:
crbug.com/593596 compositing/geometry/layer-due-to-layer-children-deep.html [
Failure ]
You can also mark them NeedsRebaseline.

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right):

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:89: newOverflowClip =
Is this change necessary?

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:212: // The rect now
needs to be transformed to the local space of this PaintLayer.
Nit: 80 chars

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:488:
layerBoundsWithVisualOverflow);  // PaintLayer are in physical coordinates, so
the overflow has to be flipped.
Nit: 80 chars

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.h (right):

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipper.h:175: explicit
PaintLayerClipper(const PaintLayer&, bool useGeometryMapper);
Can you avoid the new parameter but check REF::Spv2Enabled in this constructor?

[Xianzhu, 2016-10-06 00:15:10]

lgtm

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.h (right):

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipper.h:175: explicit
PaintLayerClipper(const PaintLayer&, bool useGeometryMapper);
On 2016/10/06 00:13:32, Xianzhu wrote:
> Can you avoid the new parameter but check REF::Spv2Enabled in this
constructor? 

Never mind. Just noticed that the rect checking code need this.

[commit-bot: I haz the power, 2016-10-06 00:28:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 00:28:06]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-10-06 17:11:08]

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
(right):

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:2162:
crbug.com/593596 compositing/geometry/layer-due-to-layer-children-deep.html [
Failure ]
On 2016/10/06 at 00:13:32, Xianzhu wrote:
> You can also mark them NeedsRebaseline.

I can't do that without breaking SPv1 expectations or adding them to
virtual/spv2, no?

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right):

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:89: newOverflowClip =
On 2016/10/06 at 00:13:32, Xianzhu wrote:
> Is this change necessary?

Reverted.

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:212: // The rect now
needs to be transformed to the local space of this PaintLayer.
On 2016/10/06 at 00:13:32, Xianzhu wrote:
> Nit: 80 chars

Fixed.

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:488:
layerBoundsWithVisualOverflow);  // PaintLayer are in physical coordinates, so
the overflow has to be flipped.
On 2016/10/06 at 00:13:32, Xianzhu wrote:
> Nit: 80 chars

Fixed.

[chrishtr, 2016-10-06 17:17:00]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-10-06 17:17:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2238883006/#ps380001
(title: "none")

[commit-bot: I haz the power, 2016-10-06 17:17:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-10-06 17:26:19]

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
(right):

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:2162:
crbug.com/593596 compositing/geometry/layer-due-to-layer-children-deep.html [
Failure ]
On 2016/10/06 17:11:08, chrishtr wrote:
> On 2016/10/06 at 00:13:32, Xianzhu wrote:
> > You can also mark them NeedsRebaseline.
> 
> I can't do that without breaking SPv1 expectations or adding them to
> virtual/spv2, no?

The NeedsRebaseline won't cause real rebaseline until the expectations are
merged into the main TestExpectations. It seems better than Failure because it
states the actual result is valid, while Failure states we need to fix it.

[chrishtr, 2016-10-06 17:26:48]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-10-06 17:28:04]

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
(right):

https://codereview.chromium.org/2238883006/diff/340001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:2162:
crbug.com/593596 compositing/geometry/layer-due-to-layer-children-deep.html [
Failure ]
On 2016/10/06 at 17:26:19, Xianzhu wrote:
> On 2016/10/06 17:11:08, chrishtr wrote:
> > On 2016/10/06 at 00:13:32, Xianzhu wrote:
> > > You can also mark them NeedsRebaseline.
> > 
> > I can't do that without breaking SPv1 expectations or adding them to
> > virtual/spv2, no?
> 
> The NeedsRebaseline won't cause real rebaseline until the expectations are
merged into the main TestExpectations. It seems better than Failure because it
states the actual result is valid, while Failure states we need to fix it.

Good point. Done.

[chrishtr, 2016-10-06 17:28:46]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-10-06 17:28:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2238883006/#ps400001
(title: "none")

[commit-bot: I haz the power, 2016-10-06 17:29:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 17:39:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 17:39:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chrishtr, 2016-10-06 21:35:35]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-10-06 21:35:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2238883006/#ps420001
(title: "none")

[commit-bot: I haz the power, 2016-10-06 21:36:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 21:47:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 21:47:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chrishtr, 2016-10-06 21:51:13]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-10-06 21:51:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2238883006/#ps440001
(title: "none")

[commit-bot: I haz the power, 2016-10-06 21:51:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 23:24:26]

Committed patchset #23 (id:440001)

[commit-bot: I haz the power, 2016-10-06 23:26:44]

Description was changed from

==========
Use GeometryMapper to implement PaintLayerClipper.

BUG=593596

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use GeometryMapper to implement PaintLayerClipper.

BUG=593596

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c
Cr-Commit-Position: refs/heads/master@{#423731}
==========

[commit-bot: I haz the power, 2016-10-06 23:26:46]

Patchset 23 (id:??) landed as
https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c
Cr-Commit-Position: refs/heads/master@{#423731}