third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js - Issue 2238883004: DevTools: Split off SourcesTextEditor from CodeMirrorTextEditor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

Issue 2238883004: DevTools: Split off SourcesTextEditor from CodeMirrorTextEditor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Stray line Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js ('k') | third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

index 1d24736d5403f922fe93f5e8b74a28f1aa5da031..fdda3c26e1fa99b3225f1d5f6f923b652dbf2a40 100644

--- a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

@@ -33,7 +33,7 @@

* @extends {WebInspector.SimpleView}

* @implements {WebInspector.Searchable}

* @implements {WebInspector.Replaceable}

- * @implements {WebInspector.TextEditorDelegate}

+ * @implements {WebInspector.SourcesTextEditorDelegate}

* @param {string} url

* @param {function(): !Promise<?string>} lazyContent

@@ -44,7 +44,7 @@ WebInspector.SourceFrame = function(url, lazyContent)

this._url = url;

this._lazyContent = lazyContent;

- this._textEditor = new WebInspector.CodeMirrorTextEditor(this);

+ this._textEditor = new WebInspector.SourcesTextEditor(this);

this._currentSearchResultIndex = -1;

this._searchResults = [];