Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/interpreter/bytecode-peephole-optimizer.h

Issue 2238853002: [Interpreter] Remove LdaConstant+ToName peephole optimization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@offheap_internalize
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INTERPRETER_BYTECODE_PEEPHOLE_OPTIMIZER_H_ 5 #ifndef V8_INTERPRETER_BYTECODE_PEEPHOLE_OPTIMIZER_H_
6 #define V8_INTERPRETER_BYTECODE_PEEPHOLE_OPTIMIZER_H_ 6 #define V8_INTERPRETER_BYTECODE_PEEPHOLE_OPTIMIZER_H_
7 7
8 #include "src/interpreter/bytecode-peephole-table.h" 8 #include "src/interpreter/bytecode-peephole-table.h"
9 #include "src/interpreter/bytecode-pipeline.h" 9 #include "src/interpreter/bytecode-pipeline.h"
10 10
11 namespace v8 { 11 namespace v8 {
12 namespace internal { 12 namespace internal {
13 namespace interpreter { 13 namespace interpreter {
14 14
15 class ConstantArrayBuilder;
16 class BytecodePeepholeActionAndData; 15 class BytecodePeepholeActionAndData;
17 16
18 // An optimization stage for performing peephole optimizations on 17 // An optimization stage for performing peephole optimizations on
19 // generated bytecode. The optimizer may buffer one bytecode 18 // generated bytecode. The optimizer may buffer one bytecode
20 // internally. 19 // internally.
21 class BytecodePeepholeOptimizer final : public BytecodePipelineStage, 20 class BytecodePeepholeOptimizer final : public BytecodePipelineStage,
22 public ZoneObject { 21 public ZoneObject {
23 public: 22 public:
24 BytecodePeepholeOptimizer(ConstantArrayBuilder* constant_array_builder, 23 explicit BytecodePeepholeOptimizer(BytecodePipelineStage* next_stage);
25 BytecodePipelineStage* next_stage);
26 24
27 // BytecodePipelineStage interface. 25 // BytecodePipelineStage interface.
28 void Write(BytecodeNode* node) override; 26 void Write(BytecodeNode* node) override;
29 void WriteJump(BytecodeNode* node, BytecodeLabel* label) override; 27 void WriteJump(BytecodeNode* node, BytecodeLabel* label) override;
30 void BindLabel(BytecodeLabel* label) override; 28 void BindLabel(BytecodeLabel* label) override;
31 void BindLabel(const BytecodeLabel& target, BytecodeLabel* label) override; 29 void BindLabel(const BytecodeLabel& target, BytecodeLabel* label) override;
32 Handle<BytecodeArray> ToBytecodeArray( 30 Handle<BytecodeArray> ToBytecodeArray(
33 int fixed_register_count, int parameter_count, 31 int fixed_register_count, int parameter_count,
34 Handle<FixedArray> handler_table) override; 32 Handle<FixedArray> handler_table) override;
35 33
36 private: 34 private:
37 #define DECLARE_ACTION(Action) \ 35 #define DECLARE_ACTION(Action) \
38 void Action(BytecodeNode* const node, \ 36 void Action(BytecodeNode* const node, \
39 const PeepholeActionAndData* const action_data = nullptr); 37 const PeepholeActionAndData* const action_data = nullptr);
40 PEEPHOLE_ACTION_LIST(DECLARE_ACTION) 38 PEEPHOLE_ACTION_LIST(DECLARE_ACTION)
41 #undef DECLARE_ACTION 39 #undef DECLARE_ACTION
42 40
43 void ApplyPeepholeAction(BytecodeNode* const node); 41 void ApplyPeepholeAction(BytecodeNode* const node);
44 void Flush(); 42 void Flush();
45 bool CanElideLastBasedOnSourcePosition( 43 bool CanElideLastBasedOnSourcePosition(
46 const BytecodeNode* const current) const; 44 const BytecodeNode* const current) const;
47 void InvalidateLast(); 45 void InvalidateLast();
48 bool LastIsValid() const; 46 bool LastIsValid() const;
49 void SetLast(const BytecodeNode* const node); 47 void SetLast(const BytecodeNode* const node);
50 48
51 Handle<Object> GetConstantForIndexOperand(const BytecodeNode* const node,
52 int index) const;
53
54 BytecodePipelineStage* next_stage() const { return next_stage_; } 49 BytecodePipelineStage* next_stage() const { return next_stage_; }
55 BytecodeNode* last() { return &last_; } 50 BytecodeNode* last() { return &last_; }
56 51
57 ConstantArrayBuilder* constant_array_builder_;
58 BytecodePipelineStage* next_stage_; 52 BytecodePipelineStage* next_stage_;
59 BytecodeNode last_; 53 BytecodeNode last_;
60 54
61 DISALLOW_COPY_AND_ASSIGN(BytecodePeepholeOptimizer); 55 DISALLOW_COPY_AND_ASSIGN(BytecodePeepholeOptimizer);
62 }; 56 };
63 57
64 } // namespace interpreter 58 } // namespace interpreter
65 } // namespace internal 59 } // namespace internal
66 } // namespace v8 60 } // namespace v8
67 61
68 #endif // V8_INTERPRETER_BYTECODE_PEEPHOLE_OPTIMIZER_H_ 62 #endif // V8_INTERPRETER_BYTECODE_PEEPHOLE_OPTIMIZER_H_
OLDNEW
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/bytecode-peephole-optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698