Issue 22388003: Revert "Deprecate self and total time getters and total sample count getter on CpuProfileNode"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22388003: Revert "Deprecate self and total time getters and total sample count getter on CpuProfileNode" (Closed)

Created:
7 years, 4 months ago by yurys

Modified:
7 years, 4 months ago

Reviewers:
Sven Panne, alph

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Deprecate self and total time getters and total sample count getter on CpuProfileNode" This reverts commit r16116 due to WebKit compilation breakage. Will reland it once Blink r155755 is rolled into Chromium. TBR=svenpanne@chromium.org BUG=None Committed: https://code.google.com/p/v8/source/detail?r=16117

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -19 lines)			Patch
M	include/v8-profiler.h	View	1 chunk	+4 lines, -11 lines	0 comments	Download
M	src/api.cc	View	6 chunks	+14 lines, -5 lines	0 comments	Download
M	src/profile-generator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r16117.

Expand Messages | Collapse Messages