Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2238773002: [Media Router WebUI] Move replace route responsibility to extension (Closed)

Created:
4 years, 4 months ago by btolsch
Modified:
4 years, 4 months ago
Reviewers:
imcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Move replace route responsibility to extension Currently the MR dialog controls the replace route functionality by stopping the current route and starting a new one when that completes. This doesn't allow the extension to optimize the change of source. This change replaces the current UI behavior by simply calling CreateRoute with the same sink and new source. This requires an extension change to support accepting CreateRoute calls to a sink with an existing route. BUG=614144 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2142613002 Cr-Commit-Position: refs/heads/master@{#410607} (cherry picked from commit bbc838f3a5ed945462a29818591753e2cdb04f5c)

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
btolsch
Merging to M53, no conflicts. PTAL, thanks!
4 years, 4 months ago (2016-08-11 04:05:51 UTC) #2
imcheng
lgtm
4 years, 4 months ago (2016-08-11 04:14:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238773002/1
4 years, 4 months ago (2016-08-11 04:14:54 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 04:17:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698